Get rid of most instance of 'foo == NULL'

core/src/fxcrt/fx_xml_parser.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xml_int.h"
 
 #include "core/include/fxcrt/fx_ext.h"
 #include "core/include/fxcrt/fx_xml.h"
@@ skipping 445 matching lines @@
             if (!bCDATA && !m_bSaveSpaceChars) {
               dataStr.TrimRight(L" \t\r\n");
             }
             InsertContentSegment(bCDATA, dataStr, pElement);
             content.Clear();
             decoder.Clear();
             bCDATA = FALSE;
             iState = 0;
             m_dwIndex--;
             CXML_Element* pSubElement = ParseElement(pElement, TRUE);
-            if (pSubElement == NULL) {
+            if (!pSubElement) {
               break;
             }
             pSubElement->m_pParent = pElement;
             pElement->m_Children.Add((void*)CXML_Element::Element);
             pElement->m_Children.Add(pSubElement);
             SkipWhiteSpaces();
           }
           break;
         case 2:
           if (ch == '[') {
@@ skipping 283 matching lines @@
   for (int i = 0; i < m_Children.GetSize(); i += 2) {
     if ((ChildType)(uintptr_t)m_Children.GetAt(i) == Element &&
         (CXML_Element*)m_Children.GetAt(i + 1) == pChild) {
       return (FX_DWORD)(i >> 1);
     }
   }
   return (FX_DWORD)-1;
 }
 const CFX_WideString* CXML_AttrMap::Lookup(const CFX_ByteStringC& space,
                                            const CFX_ByteStringC& name) const {
-  if (m_pMap == NULL) {
+  if (!m_pMap) {
     return NULL;
   }
   for (int i = 0; i < m_pMap->GetSize(); i++) {
     CXML_AttrItem& item = GetAt(i);
     if ((space.IsEmpty() || item.m_QSpaceName == space) &&
         item.m_AttrName == name) {
       return &item.m_Value;
     }
   }
   return NULL;
@@ skipping 15 matching lines @@
   CXML_AttrItem* pItem = (CXML_AttrItem*)m_pMap->AddSpace();
   if (!pItem) {
     return;
   }
   pItem->m_QSpaceName = space;
   pItem->m_AttrName = name;
   pItem->m_Value = value;
 }
 void CXML_AttrMap::RemoveAt(const CFX_ByteStringC& space,
                             const CFX_ByteStringC& name) {
-  if (m_pMap == NULL) {
+  if (!m_pMap) {
     return;
   }
   for (int i = 0; i < m_pMap->GetSize(); i++) {
     CXML_AttrItem& item = GetAt(i);
     if ((space.IsEmpty() || item.m_QSpaceName == space) &&
         item.m_AttrName == name) {
       m_pMap->RemoveAt(i);
       return;
     }
   }
 }
 int CXML_AttrMap::GetSize() const {
-  return m_pMap == NULL ? 0 : m_pMap->GetSize();
+  return m_pMap ? m_pMap->GetSize() : 0;
 }
 CXML_AttrItem& CXML_AttrMap::GetAt(int index) const {
   return (*m_pMap)[index];
 }
 void CXML_AttrMap::RemoveAll() {
   if (!m_pMap) {
     return;
   }
   m_pMap->RemoveAll();
   delete m_pMap;
   m_pMap = NULL;
 }