Get rid of most instance of 'foo == NULL'

core/src/fxcodec/codec/fx_codec_icc.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "codec_int.h"
 #include "core/include/fxcodec/fx_codec.h"
 #include "third_party/lcms2-2.6/include/lcms2.h"
 
@@ skipping 84 matching lines @@
                              int32_t nDstComponents,
                              int intent,
                              FX_DWORD dwSrcFormat = Icc_FORMAT_DEFAULT,
                              FX_DWORD dwDstFormat = Icc_FORMAT_DEFAULT) {
   cmsHPROFILE srcProfile = NULL;
   cmsHPROFILE dstProfile = NULL;
   cmsHTRANSFORM hTransform = NULL;
   CLcmsCmm* pCmm = NULL;
   nSrcComponents = 0;
   srcProfile = cmsOpenProfileFromMem((void*)pSrcProfileData, dwSrcProfileSize);
-  if (srcProfile == NULL) {
+  if (!srcProfile) {
     return NULL;
   }
-  if (pDstProfileData == NULL && dwDstProfileSize == 0 && nDstComponents == 3) {
+  if (!pDstProfileData && dwDstProfileSize == 0 && nDstComponents == 3) {
     dstProfile = cmsCreate_sRGBProfile();
   } else {
     dstProfile =
         cmsOpenProfileFromMem((void*)pDstProfileData, dwDstProfileSize);
   }
-  if (dstProfile == NULL) {
+  if (!dstProfile) {
     cmsCloseProfile(srcProfile);
     return NULL;
   }
   int srcFormat;
   FX_BOOL bLab = FALSE;
   cmsColorSpaceSignature srcCS = cmsGetColorSpace(srcProfile);
   nSrcComponents = GetCSComponents(srcCS);
   if (srcCS == cmsSigLabData) {
     srcFormat =
         COLORSPACE_SH(PT_Lab) | CHANNELS_SH(nSrcComponents) | BYTES_SH(0);
@@ skipping 21 matching lines @@
                                       TYPE_BGR_8, intent, 0);
       break;
     case cmsSigCmykData:
       hTransform = cmsCreateTransform(
           srcProfile, srcFormat, dstProfile,
           T_DOSWAP(dwDstFormat) ? TYPE_KYMC_8 : TYPE_CMYK_8, intent, 0);
       break;
     default:
       break;
   }
-  if (hTransform == NULL) {
+  if (!hTransform) {
     cmsCloseProfile(srcProfile);
     cmsCloseProfile(dstProfile);
     return NULL;
   }
   pCmm = new CLcmsCmm;
   pCmm->m_nSrcComponents = nSrcComponents;
   pCmm->m_nDstComponents = nDstComponents;
   pCmm->m_hTransform = hTransform;
   pCmm->m_bLab = bLab;
   cmsCloseProfile(srcProfile);
   cmsCloseProfile(dstProfile);
   return pCmm;
 }
 void* IccLib_CreateTransform_sRGB(const unsigned char* pProfileData,
                                   FX_DWORD dwProfileSize,
                                   int32_t& nComponents,
                                   int32_t intent,
                                   FX_DWORD dwSrcFormat) {
   return IccLib_CreateTransform(pProfileData, dwProfileSize, nComponents, NULL,
                                 0, 3, intent, dwSrcFormat);
 }
 void IccLib_DestroyTransform(void* pTransform) {
-  if (pTransform == NULL) {
+  if (!pTransform) {
     return;
   }
   cmsDeleteTransform(((CLcmsCmm*)pTransform)->m_hTransform);
   delete (CLcmsCmm*)pTransform;
 }
 void IccLib_Translate(void* pTransform,
                       FX_DWORD nSrcComponents,
                       FX_FLOAT* pSrcValues,
                       FX_FLOAT* pDestValues) {
-  if (pTransform == NULL) {
+  if (!pTransform) {
     return;
   }
   CLcmsCmm* p = (CLcmsCmm*)pTransform;
   uint8_t output[4];
   if (p->m_bLab) {
     CFX_FixedBufGrow<double, 16> inputs(nSrcComponents);
     double* input = inputs;
     for (FX_DWORD i = 0; i < nSrcComponents; i++) {
       input[i] = pSrcValues[i];
     }
@@ skipping 35 matching lines @@
                            int32_t pixels) {
   cmsDoTransform(((CLcmsCmm*)pTransform)->m_hTransform, (void*)pSrc, pDest,
                  pixels);
 }
 void* CreateProfile_Gray(double gamma) {
   cmsCIExyY* D50 = (cmsCIExyY*)cmsD50_xyY();
   if (!cmsWhitePointFromTemp(D50, 6504)) {
     return NULL;
   }
   cmsToneCurve* curve = cmsBuildGamma(NULL, gamma);
-  if (curve == NULL) {
+  if (!curve) {
     return NULL;
   }
   void* profile = cmsCreateGrayProfile(D50, curve);
   cmsFreeToneCurve(curve);
   return profile;
 }
 ICodec_IccModule::IccCS GetProfileCSFromHandle(void* pProfile) {
-  if (pProfile == NULL) {
+  if (!pProfile) {
     return ICodec_IccModule::IccCS_Unknown;
   }
   switch (cmsGetColorSpace(pProfile)) {
     case cmsSigXYZData:
       return ICodec_IccModule::IccCS_XYZ;
     case cmsSigLabData:
       return ICodec_IccModule::IccCS_Lab;
     case cmsSigLuvData:
       return ICodec_IccModule::IccCS_Luv;
     case cmsSigYCbCrData:
@@ skipping 15 matching lines @@
     default:
       return ICodec_IccModule::IccCS_Unknown;
   }
 }
 ICodec_IccModule::IccCS CCodec_IccModule::GetProfileCS(
     const uint8_t* pProfileData,
     FX_DWORD dwProfileSize) {
   ICodec_IccModule::IccCS cs;
   cmsHPROFILE hProfile =
       cmsOpenProfileFromMem((void*)pProfileData, dwProfileSize);
-  if (hProfile == NULL) {
+  if (!hProfile) {
     return IccCS_Unknown;
   }
   cs = GetProfileCSFromHandle(hProfile);
   if (hProfile) {
     cmsCloseProfile(hProfile);
   }
   return cs;
 }
 ICodec_IccModule::IccCS CCodec_IccModule::GetProfileCS(IFX_FileRead* pFile) {
-  if (pFile == NULL) {
+  if (!pFile) {
     return IccCS_Unknown;
   }
   ICodec_IccModule::IccCS cs;
   FX_DWORD dwSize = (FX_DWORD)pFile->GetSize();
   uint8_t* pBuf = FX_Alloc(uint8_t, dwSize);
   pFile->ReadBlock(pBuf, 0, dwSize);
   cs = GetProfileCS(pBuf, dwSize);
   FX_Free(pBuf);
   return cs;
 }
@@ skipping 159 matching lines @@
     ICodec_IccModule::IccParam* pOutputParam,
     ICodec_IccModule::IccParam* pProofParam,
     FX_DWORD dwIntent,
     FX_DWORD dwFlag,
     FX_DWORD dwPrfIntent,
     FX_DWORD dwPrfFlag) {
   CLcmsCmm* pCmm = NULL;
   ASSERT(pInputParam && pOutputParam);
   CFX_ByteStringKey key;
   void* pInputProfile = CreateProfile(pInputParam, Icc_CLASS_INPUT, &key);
-  if (pInputProfile == NULL) {
+  if (!pInputProfile) {
     return NULL;
   }
   void* pOutputProfile = CreateProfile(pOutputParam, Icc_CLASS_OUTPUT, &key);
-  if (pOutputProfile == NULL) {
+  if (!pOutputProfile) {
     return NULL;
   }
   FX_DWORD dwInputProfileType =
       TransferProfileType(pInputProfile, pInputParam->dwFormat);
   FX_DWORD dwOutputProfileType =
       TransferProfileType(pOutputProfile, pOutputParam->dwFormat);
   if (dwInputProfileType == 0 || dwOutputProfileType == 0) {
     return NULL;
   }
   void* pProofProfile = NULL;
@@ skipping 1477 matching lines @@
   uint8_t c1 = FXSYS_round(c * 255);
   uint8_t m1 = FXSYS_round(m * 255);
   uint8_t y1 = FXSYS_round(y * 255);
   uint8_t k1 = FXSYS_round(k * 255);
   uint8_t r, g, b;
   AdobeCMYK_to_sRGB1(c1, m1, y1, k1, r, g, b);
   R = 1.0f * r / 255;
   G = 1.0f * g / 255;
   B = 1.0f * b / 255;
 }