Get rid of most instance of 'foo == NULL'

core/src/fpdfdoc/doc_utils.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/include/fpdfdoc/fpdf_doc.h"
 #include "doc_utils.h"
 
 static const int FPDFDOC_UTILS_MAXRECURSION = 32;
@@ skipping 206 matching lines @@
   if (syntax.FindTagParam("Tm", 6)) {
     FX_FLOAT f[6];
     for (int i = 0; i < 6; i++) {
       f[i] = FX_atof((CFX_ByteString)syntax.GetWord());
     }
     tm.Set(f[0], f[1], f[2], f[3], f[4], f[5]);
   }
   return tm;
 }
 void InitInterFormDict(CPDF_Dictionary*& pFormDict, CPDF_Document* pDocument) {
-  if (pDocument == NULL) {
+  if (!pDocument) {
     return;
   }
-  if (pFormDict == NULL) {
+  if (!pFormDict) {
     pFormDict = CPDF_Dictionary::Create();
-    if (pFormDict == NULL) {
-      return;
-    }
     FX_DWORD dwObjNum = pDocument->AddIndirectObject(pFormDict);
     CPDF_Dictionary* pRoot = pDocument->GetRoot();
     pRoot->SetAtReference("AcroForm", pDocument, dwObjNum);
   }
   CFX_ByteString csDA;
   if (!pFormDict->KeyExist("DR")) {
     CPDF_Font* pFont = NULL;
     CFX_ByteString csBaseName, csDefault;
     uint8_t charSet = CPDF_InterForm::GetNativeCharSet();
     pFont = CPDF_InterForm::AddStandardFont(pDocument, "Helvetica");
     if (pFont) {
       AddInterFormFont(pFormDict, pDocument, pFont, csBaseName);
       csDefault = csBaseName;
     }
     if (charSet != 0) {
       CFX_ByteString csFontName = CPDF_InterForm::GetNativeFont(charSet, NULL);
-      if (pFont == NULL || csFontName != "Helvetica") {
+      if (!pFont || csFontName != "Helvetica") {
         pFont = CPDF_InterForm::AddNativeFont(pDocument);
         if (pFont) {
           csBaseName = "";
           AddInterFormFont(pFormDict, pDocument, pFont, csBaseName);
           csDefault = csBaseName;
         }
       }
     }
     if (pFont) {
       csDA = "/" + PDF_NameEncode(csDefault) + " 0 Tf";
     }
   }
   if (!csDA.IsEmpty()) {
     csDA += " ";
   }
   csDA += "0 g";
   if (!pFormDict->KeyExist("DA")) {
     pFormDict->SetAtString("DA", csDA);
   }
 }
 FX_DWORD CountInterFormFonts(CPDF_Dictionary* pFormDict) {
-  if (pFormDict == NULL) {
+  if (!pFormDict) {
     return 0;
   }
   CPDF_Dictionary* pDR = pFormDict->GetDict("DR");
-  if (pDR == NULL) {
+  if (!pDR) {
     return 0;
   }
   CPDF_Dictionary* pFonts = pDR->GetDict("Font");
-  if (pFonts == NULL) {
+  if (!pFonts) {
     return 0;
   }
   FX_DWORD dwCount = 0;
   FX_POSITION pos = pFonts->GetStartPos();
   while (pos) {
     CPDF_Object* pObj = NULL;
     CFX_ByteString csKey;
     pObj = pFonts->GetNextElement(pos, csKey);
-    if (pObj == NULL) {
+    if (!pObj) {
       continue;
     }
     if (CPDF_Dictionary* pDirect = ToDictionary(pObj->GetDirect())) {
       if (pDirect->GetString("Type") == "Font") {
         dwCount++;
       }
     }
   }
   return dwCount;
 }
 CPDF_Font* GetInterFormFont(CPDF_Dictionary* pFormDict,
                             CPDF_Document* pDocument,
                             FX_DWORD index,
                             CFX_ByteString& csNameTag) {
-  if (pFormDict == NULL) {
+  if (!pFormDict) {
     return NULL;
   }
   CPDF_Dictionary* pDR = pFormDict->GetDict("DR");
-  if (pDR == NULL) {
+  if (!pDR) {
     return NULL;
   }
   CPDF_Dictionary* pFonts = pDR->GetDict("Font");
-  if (pFonts == NULL) {
+  if (!pFonts) {
     return NULL;
   }
   FX_DWORD dwCount = 0;
   FX_POSITION pos = pFonts->GetStartPos();
   while (pos) {
     CPDF_Object* pObj = NULL;
     CFX_ByteString csKey;
     pObj = pFonts->GetNextElement(pos, csKey);
-    if (pObj == NULL) {
+    if (!pObj) {
       continue;
     }
     CPDF_Dictionary* pElement = ToDictionary(pObj->GetDirect());
     if (!pElement)
       continue;
     if (pElement->GetString("Type") != "Font")
       continue;
     if (dwCount == index) {
       csNameTag = csKey;
       return pDocument->LoadFont(pElement);
     }
     dwCount++;
   }
   return NULL;
 }
 CPDF_Font* GetInterFormFont(CPDF_Dictionary* pFormDict,
                             CPDF_Document* pDocument,
                             CFX_ByteString csNameTag) {
   CFX_ByteString csAlias = PDF_NameDecode(csNameTag);
-  if (pFormDict == NULL || csAlias.IsEmpty()) {
+  if (!pFormDict || csAlias.IsEmpty()) {
     return NULL;
   }
   CPDF_Dictionary* pDR = pFormDict->GetDict("DR");
-  if (pDR == NULL) {
+  if (!pDR) {
     return NULL;
   }
   CPDF_Dictionary* pFonts = pDR->GetDict("Font");
-  if (pFonts == NULL) {
+  if (!pFonts) {
     return NULL;
   }
   CPDF_Dictionary* pElement = pFonts->GetDict(csAlias);
-  if (pElement == NULL) {
+  if (!pElement) {
     return NULL;
   }
   if (pElement->GetString("Type") == "Font") {
     return pDocument->LoadFont(pElement);
   }
   return NULL;
 }
 CPDF_Font* GetInterFormFont(CPDF_Dictionary* pFormDict,
                             CPDF_Document* pDocument,
                             CFX_ByteString csFontName,
                             CFX_ByteString& csNameTag) {
-  if (pFormDict == NULL || csFontName.IsEmpty()) {
+  if (!pFormDict || csFontName.IsEmpty()) {
     return NULL;
   }
   CPDF_Dictionary* pDR = pFormDict->GetDict("DR");
-  if (pDR == NULL) {
+  if (!pDR) {
     return NULL;
   }
   CPDF_Dictionary* pFonts = pDR->GetDict("Font");
-  if (pFonts == NULL) {
+  if (!pFonts) {
     return NULL;
   }
   FX_POSITION pos = pFonts->GetStartPos();
   while (pos) {
     CPDF_Object* pObj = NULL;
     CFX_ByteString csKey;
     pObj = pFonts->GetNextElement(pos, csKey);
-    if (pObj == NULL) {
+    if (!pObj) {
       continue;
     }
     CPDF_Dictionary* pElement = ToDictionary(pObj->GetDirect());
     if (!pElement)
       continue;
     if (pElement->GetString("Type") != "Font")
       continue;
 
     CPDF_Font* pFind = pDocument->LoadFont(pElement);
     if (!pFind)
       continue;
 
     CFX_ByteString csBaseFont;
     csBaseFont = pFind->GetBaseFont();
     csBaseFont.Remove(' ');
     if (csBaseFont == csFontName) {
       csNameTag = csKey;
       return pFind;
     }
   }
   return NULL;
 }
 CPDF_Font* GetNativeInterFormFont(CPDF_Dictionary* pFormDict,
                                   CPDF_Document* pDocument,
                                   uint8_t charSet,
                                   CFX_ByteString& csNameTag) {
-  if (pFormDict == NULL) {
+  if (!pFormDict) {
     return NULL;
   }
   CPDF_Dictionary* pDR = pFormDict->GetDict("DR");
-  if (pDR == NULL) {
+  if (!pDR) {
     return NULL;
   }
   CPDF_Dictionary* pFonts = pDR->GetDict("Font");
-  if (pFonts == NULL) {
+  if (!pFonts) {
     return NULL;
   }
   FX_POSITION pos = pFonts->GetStartPos();
   while (pos) {
     CPDF_Object* pObj = NULL;
     CFX_ByteString csKey;
     pObj = pFonts->GetNextElement(pos, csKey);
-    if (pObj == NULL) {
+    if (!pObj) {
       continue;
     }
     CPDF_Dictionary* pElement = ToDictionary(pObj->GetDirect());
     if (!pElement)
       continue;
     if (pElement->GetString("Type") != "Font")
       continue;
     CPDF_Font* pFind = pDocument->LoadFont(pElement);
-    if (pFind == NULL) {
+    if (!pFind) {
       continue;
     }
     CFX_SubstFont* pSubst = (CFX_SubstFont*)pFind->GetSubstFont();
-    if (pSubst == NULL) {
+    if (!pSubst) {
       continue;
     }
     if (pSubst->m_Charset == (int)charSet) {
       csNameTag = csKey;
       return pFind;
     }
   }
   return NULL;
 }
 CPDF_Font* GetNativeInterFormFont(CPDF_Dictionary* pFormDict,
                                   CPDF_Document* pDocument,
                                   CFX_ByteString& csNameTag) {
   csNameTag = "";
   uint8_t charSet = CPDF_InterForm::GetNativeCharSet();
   CFX_SubstFont* pSubst;
   CPDF_Font* pFont = GetDefaultInterFormFont(pFormDict, pDocument);
   if (pFont) {
     pSubst = (CFX_SubstFont*)pFont->GetSubstFont();
     if (pSubst && pSubst->m_Charset == (int)charSet) {
       FindInterFormFont(pFormDict, pFont, csNameTag);
       return pFont;
     }
   }
   return GetNativeInterFormFont(pFormDict, pDocument, charSet, csNameTag);
 }
 FX_BOOL FindInterFormFont(CPDF_Dictionary* pFormDict,
                           const CPDF_Font* pFont,
                           CFX_ByteString& csNameTag) {
-  if (pFormDict == NULL || pFont == NULL) {
+  if (!pFormDict || !pFont) {
     return FALSE;
   }
   CPDF_Dictionary* pDR = pFormDict->GetDict("DR");
-  if (pDR == NULL) {
+  if (!pDR) {
     return FALSE;
   }
   CPDF_Dictionary* pFonts = pDR->GetDict("Font");
-  if (pFonts == NULL) {
+  if (!pFonts) {
     return FALSE;
   }
   FX_POSITION pos = pFonts->GetStartPos();
   while (pos) {
     CPDF_Object* pObj = NULL;
     CFX_ByteString csKey;
     pObj = pFonts->GetNextElement(pos, csKey);
-    if (pObj == NULL) {
+    if (!pObj) {
       continue;
     }
     CPDF_Dictionary* pElement = ToDictionary(pObj->GetDirect());
     if (!pElement)
       continue;
     if (pElement->GetString("Type") != "Font") {
       continue;
     }
     if (pFont->GetFontDict() == pElement) {
       csNameTag = csKey;
       return TRUE;
     }
   }
   return FALSE;
 }
 FX_BOOL FindInterFormFont(CPDF_Dictionary* pFormDict,
                           CPDF_Document* pDocument,
                           CFX_ByteString csFontName,
                           CPDF_Font*& pFont,
                           CFX_ByteString& csNameTag) {
-  if (pFormDict == NULL) {
+  if (!pFormDict) {
     return FALSE;
   }
   CPDF_Dictionary* pDR = pFormDict->GetDict("DR");
-  if (pDR == NULL) {
+  if (!pDR) {
     return FALSE;
   }
   CPDF_Dictionary* pFonts = pDR->GetDict("Font");
-  if (pFonts == NULL) {
+  if (!pFonts) {
     return FALSE;
   }
   if (csFontName.GetLength() > 0) {
     csFontName.Remove(' ');
   }
   FX_POSITION pos = pFonts->GetStartPos();
   while (pos) {
     CPDF_Object* pObj = NULL;
     CFX_ByteString csKey, csTmp;
     pObj = pFonts->GetNextElement(pos, csKey);
-    if (pObj == NULL) {
+    if (!pObj) {
       continue;
     }
     CPDF_Dictionary* pElement = ToDictionary(pObj->GetDirect());
     if (!pElement)
       continue;
     if (pElement->GetString("Type") != "Font") {
       continue;
     }
     pFont = pDocument->LoadFont(pElement);
-    if (pFont == NULL) {
+    if (!pFont) {
       continue;
     }
     CFX_ByteString csBaseFont;
     csBaseFont = pFont->GetBaseFont();
     csBaseFont.Remove(' ');
     if (csBaseFont == csFontName) {
       csNameTag = csKey;
       return TRUE;
     }
   }
   return FALSE;
 }
 void AddInterFormFont(CPDF_Dictionary*& pFormDict,
                       CPDF_Document* pDocument,
                       const CPDF_Font* pFont,
                       CFX_ByteString& csNameTag) {
-  if (pFont == NULL) {
+  if (!pFont) {
     return;
   }
-  if (pFormDict == NULL) {
+  if (!pFormDict) {
     InitInterFormDict(pFormDict, pDocument);
   }
   CFX_ByteString csTag;
   if (FindInterFormFont(pFormDict, pFont, csTag)) {
     csNameTag = csTag;
     return;
   }
-  if (pFormDict == NULL) {
+  if (!pFormDict) {
     InitInterFormDict(pFormDict, pDocument);
   }
   CPDF_Dictionary* pDR = pFormDict->GetDict("DR");
-  if (pDR == NULL) {
+  if (!pDR) {
     pDR = CPDF_Dictionary::Create();
-    if (pDR == NULL) {
-      return;
-    }
     pFormDict->SetAt("DR", pDR);
   }
   CPDF_Dictionary* pFonts = pDR->GetDict("Font");
-  if (pFonts == NULL) {
+  if (!pFonts) {
     pFonts = CPDF_Dictionary::Create();
     pDR->SetAt("Font", pFonts);
   }
   if (csNameTag.IsEmpty()) {
     csNameTag = pFont->GetBaseFont();
   }
   csNameTag.Remove(' ');
   csNameTag =
       CPDF_InterForm::GenerateNewResourceName(pDR, "Font", 4, csNameTag);
   pFonts->SetAtReference(csNameTag, pDocument, pFont->GetFontDict());
 }
 CPDF_Font* AddNativeInterFormFont(CPDF_Dictionary*& pFormDict,
                                   CPDF_Document* pDocument,
                                   uint8_t charSet,
                                   CFX_ByteString& csNameTag) {
-  if (pFormDict == NULL) {
+  if (!pFormDict) {
     InitInterFormDict(pFormDict, pDocument);
   }
   CFX_ByteString csTemp;
   CPDF_Font* pFont =
       GetNativeInterFormFont(pFormDict, pDocument, charSet, csTemp);
   if (pFont) {
     csNameTag = csTemp;
     return pFont;
   }
   CFX_ByteString csFontName = CPDF_InterForm::GetNativeFont(charSet);
   if (!csFontName.IsEmpty()) {
     if (FindInterFormFont(pFormDict, pDocument, csFontName, pFont, csNameTag)) {
       return pFont;
     }
   }
   pFont = CPDF_InterForm::AddNativeFont(charSet, pDocument);
   if (pFont) {
     AddInterFormFont(pFormDict, pDocument, pFont, csNameTag);
   }
   return pFont;
 }
 CPDF_Font* AddNativeInterFormFont(CPDF_Dictionary*& pFormDict,
                                   CPDF_Document* pDocument,
                                   CFX_ByteString& csNameTag) {
   uint8_t charSet = CPDF_InterForm::GetNativeCharSet();
   return AddNativeInterFormFont(pFormDict, pDocument, charSet, csNameTag);
 }
 void RemoveInterFormFont(CPDF_Dictionary* pFormDict, const CPDF_Font* pFont) {
-  if (pFormDict == NULL || pFont == NULL) {
+  if (!pFormDict || !pFont) {
     return;
   }
   CFX_ByteString csTag;
   if (!FindInterFormFont(pFormDict, pFont, csTag)) {
     return;
   }
   CPDF_Dictionary* pDR = pFormDict->GetDict("DR");
   CPDF_Dictionary* pFonts = pDR->GetDict("Font");
   pFonts->RemoveAt(csTag);
 }
 void RemoveInterFormFont(CPDF_Dictionary* pFormDict, CFX_ByteString csNameTag) {
-  if (pFormDict == NULL || csNameTag.IsEmpty()) {
+  if (!pFormDict || csNameTag.IsEmpty()) {
     return;
   }
   CPDF_Dictionary* pDR = pFormDict->GetDict("DR");
-  if (pDR == NULL) {
+  if (!pDR) {
     return;
   }
   CPDF_Dictionary* pFonts = pDR->GetDict("Font");
-  if (pFonts == NULL) {
+  if (!pFonts) {
     return;
   }
   pFonts->RemoveAt(csNameTag);
 }
 CPDF_Font* GetDefaultInterFormFont(CPDF_Dictionary* pFormDict,
                                    CPDF_Document* pDocument) {
-  if (pFormDict == NULL) {
+  if (!pFormDict) {
     return NULL;
   }
   CPDF_DefaultAppearance cDA = pFormDict->GetString("DA");
   CFX_ByteString csFontNameTag;
   FX_FLOAT fFontSize;
   cDA.GetFont(csFontNameTag, fFontSize);
   return GetInterFormFont(pFormDict, pDocument, csFontNameTag);
 }
 CPDF_IconFit::ScaleMethod CPDF_IconFit::GetScaleMethod() {
   if (!m_pDict) {
     return Always;
   }
   CFX_ByteString csSW = m_pDict->GetString("SW", "A");
   if (csSW == "B") {
     return Bigger;
   }
   if (csSW == "S") {
     return Smaller;
   }
   if (csSW == "N") {
     return Never;
   }
   return Always;
 }
 FX_BOOL CPDF_IconFit::IsProportionalScale() {
-  if (m_pDict == NULL) {
+  if (!m_pDict) {
     return TRUE;
   }
   return m_pDict->GetString("S", "P") != "A";
 }
 void CPDF_IconFit::GetIconPosition(FX_FLOAT& fLeft, FX_FLOAT& fBottom) {
   fLeft = fBottom = 0.5;
-  if (m_pDict == NULL) {
+  if (!m_pDict) {
     return;
   }
   CPDF_Array* pA = m_pDict->GetArray("A");
   if (pA) {
     FX_DWORD dwCount = pA->GetCount();
     if (dwCount > 0) {
       fLeft = pA->GetNumber(0);
     }
     if (dwCount > 1) {
       fBottom = pA->GetNumber(1);
     }
   }
 }
 FX_BOOL CPDF_IconFit::GetFittingBounds() {
-  if (m_pDict == NULL) {
+  if (!m_pDict) {
     return FALSE;
   }
   return m_pDict->GetBoolean("FB");
 }
 void SaveCheckedFieldStatus(CPDF_FormField* pField,
                             CFX_ByteArray& statusArray) {
   int iCount = pField->CountControls();
   for (int i = 0; i < iCount; i++) {
     CPDF_FormControl* pControl = pField->GetControl(i);
-    if (pControl == NULL) {
+    if (!pControl) {
       continue;
     }
     statusArray.Add(pControl->IsChecked() ? 1 : 0);
   }
 }
 CPDF_Object* FPDF_GetFieldAttr(CPDF_Dictionary* pFieldDict,
                                const FX_CHAR* name,
                                int nLevel) {
   if (nLevel > FPDFDOC_UTILS_MAXRECURSION) {
     return NULL;
   }
-  if (pFieldDict == NULL) {
+  if (!pFieldDict) {
     return NULL;
   }
   CPDF_Object* pAttr = pFieldDict->GetElementValue(name);
   if (pAttr) {
     return pAttr;
   }
   CPDF_Dictionary* pParent = pFieldDict->GetDict("Parent");
-  if (pParent == NULL) {
+  if (!pParent) {
     return NULL;
   }
   return FPDF_GetFieldAttr(pParent, name, nLevel + 1);
 }