Get rid of most instance of 'foo == NULL'

core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "render_int.h"
 
 #include "core/include/fpdfapi/fpdf_pageobj.h"
 #include "core/include/fpdfapi/fpdf_render.h"
 #include "core/include/fxge/fx_ge.h"
 #include "core/src/fpdfapi/fpdf_page/pageint.h"
 
 #define SHADING_STEPS 256
 static void DrawAxialShading(CFX_DIBitmap* pBitmap,
                              CFX_Matrix* pObject2Bitmap,
                              CPDF_Dictionary* pDict,
                              CPDF_Function** pFuncs,
                              int nFuncs,
                              CPDF_ColorSpace* pCS,
                              int alpha) {
   ASSERT(pBitmap->GetFormat() == FXDIB_Argb);
   CPDF_Array* pCoords = pDict->GetArray("Coords");
-  if (pCoords == NULL) {
+  if (!pCoords) {
     return;
   }
   FX_FLOAT start_x = pCoords->GetNumber(0);
   FX_FLOAT start_y = pCoords->GetNumber(1);
   FX_FLOAT end_x = pCoords->GetNumber(2);
   FX_FLOAT end_y = pCoords->GetNumber(3);
   FX_FLOAT t_min = 0, t_max = 1.0f;
   CPDF_Array* pArray = pDict->GetArray("Domain");
   if (pArray) {
     t_min = pArray->GetNumber(0);
@@ skipping 70 matching lines @@
 }
 static void DrawRadialShading(CFX_DIBitmap* pBitmap,
                               CFX_Matrix* pObject2Bitmap,
                               CPDF_Dictionary* pDict,
                               CPDF_Function** pFuncs,
                               int nFuncs,
                               CPDF_ColorSpace* pCS,
                               int alpha) {
   ASSERT(pBitmap->GetFormat() == FXDIB_Argb);
   CPDF_Array* pCoords = pDict->GetArray("Coords");
-  if (pCoords == NULL) {
+  if (!pCoords) {
     return;
   }
   FX_FLOAT start_x = pCoords->GetNumber(0);
   FX_FLOAT start_y = pCoords->GetNumber(1);
   FX_FLOAT start_r = pCoords->GetNumber(2);
   FX_FLOAT end_x = pCoords->GetNumber(3);
   FX_FLOAT end_y = pCoords->GetNumber(4);
   FX_FLOAT end_r = pCoords->GetNumber(5);
   CFX_Matrix matrix;
   matrix.SetReverse(*pObject2Bitmap);
@@ skipping 701 matching lines @@
 }
 void CPDF_RenderStatus::DrawShading(CPDF_ShadingPattern* pPattern,
                                     CFX_Matrix* pMatrix,
                                     FX_RECT& clip_rect,
                                     int alpha,
                                     FX_BOOL bAlphaMode) {
   CPDF_Function** pFuncs = pPattern->m_pFunctions;
   int nFuncs = pPattern->m_nFuncs;
   CPDF_Dictionary* pDict = pPattern->m_pShadingObj->GetDict();
   CPDF_ColorSpace* pColorSpace = pPattern->m_pCS;
-  if (pColorSpace == NULL) {
+  if (!pColorSpace) {
     return;
   }
   FX_ARGB background = 0;
   if (!pPattern->m_bShadingObj &&
       pPattern->m_pShadingObj->GetDict()->KeyExist("Background")) {
     CPDF_Array* pBackColor =
         pPattern->m_pShadingObj->GetDict()->GetArray("Background");
     if (pBackColor &&
         pBackColor->GetCount() >= (FX_DWORD)pColorSpace->CountComponents()) {
       CFX_FixedBufGrow<FX_FLOAT, 16> comps(pColorSpace->CountComponents());
       for (int i = 0; i < pColorSpace->CountComponents(); i++) {
         comps[i] = pBackColor->GetNumber(i);
       }
       FX_FLOAT R = 0.0f, G = 0.0f, B = 0.0f;
       pColorSpace->GetRGB(comps, R, G, B);
       background = ArgbEncode(255, (int32_t)(R * 255), (int32_t)(G * 255),
                               (int32_t)(B * 255));
     }
   }
   if (pDict->KeyExist("BBox")) {
     CFX_FloatRect rect = pDict->GetRect("BBox");
     rect.Transform(pMatrix);
     clip_rect.Intersect(rect.GetOutterRect());
   }
   CPDF_DeviceBuffer buffer;
   buffer.Initialize(m_pContext, m_pDevice, &clip_rect, m_pCurObj, 150);
   CFX_Matrix FinalMatrix = *pMatrix;
   FinalMatrix.Concat(*buffer.GetMatrix());
   CFX_DIBitmap* pBitmap = buffer.GetBitmap();
-  if (pBitmap->GetBuffer() == NULL) {
+  if (!pBitmap->GetBuffer()) {
     return;
   }
   pBitmap->Clear(background);
   int fill_mode = m_Options.m_Flags;
   switch (pPattern->m_ShadingType) {
     case kInvalidShading:
     case kMaxShading:
       return;
     case kFunctionBasedShading:
       DrawFuncShading(pBitmap, &FinalMatrix, pDict, pFuncs, nFuncs, pColorSpace,
@@ skipping 236 matching lines @@
     CFX_DIBitmap* pEnlargedBitmap =
         DrawPatternBitmap(m_pContext->m_pDocument, m_pContext->m_pPageCache,
                           pPattern, pObj2Device, 8, 8, m_Options.m_Flags);
     pPatternBitmap = pEnlargedBitmap->StretchTo(width, height);
     delete pEnlargedBitmap;
   } else {
     pPatternBitmap = DrawPatternBitmap(
         m_pContext->m_pDocument, m_pContext->m_pPageCache, pPattern,
         pObj2Device, width, height, m_Options.m_Flags);
   }
-  if (pPatternBitmap == NULL) {
+  if (!pPatternBitmap) {
     m_pDevice->RestoreState();
     return;
   }
   if (m_Options.m_ColorMode == RENDER_COLOR_GRAY) {
     pPatternBitmap->ConvertColorScale(m_Options.m_ForeColor,
                                       m_Options.m_BackColor);
   }
   FX_ARGB fill_argb = GetFillArgb(pPageObj);
   int clip_width = clip_box.right - clip_box.left;
   int clip_height = clip_box.bottom - clip_box.top;
@@ skipping 43 matching lines @@
   CompositeDIBitmap(&screen, clip_box.left, clip_box.top, 0, 255,
                     FXDIB_BLEND_NORMAL, FALSE);
   m_pDevice->RestoreState();
   delete pPatternBitmap;
 }
 void CPDF_RenderStatus::DrawPathWithPattern(CPDF_PathObject* pPathObj,
                                             const CFX_Matrix* pObj2Device,
                                             CPDF_Color* pColor,
                                             FX_BOOL bStroke) {
   CPDF_Pattern* pattern = pColor->GetPattern();
-  if (pattern == NULL) {
+  if (!pattern) {
     return;
   }
   if (pattern->m_PatternType == PATTERN_TILING) {
     DrawTilingPattern((CPDF_TilingPattern*)pattern, pPathObj, pObj2Device,
                       bStroke);
   } else {
     DrawShadingPattern((CPDF_ShadingPattern*)pattern, pPathObj, pObj2Device,
                        bStroke);
   }
 }
 void CPDF_RenderStatus::ProcessPathPattern(CPDF_PathObject* pPathObj,
                                            const CFX_Matrix* pObj2Device,
                                            int& filltype,
                                            FX_BOOL& bStroke) {
   if (filltype) {
     CPDF_Color& FillColor = *pPathObj->m_ColorState.GetFillColor();
     if (FillColor.m_pCS && FillColor.m_pCS->GetFamily() == PDFCS_PATTERN) {
       DrawPathWithPattern(pPathObj, pObj2Device, &FillColor, FALSE);
       filltype = 0;
     }
   }
   if (bStroke) {
     CPDF_Color& StrokeColor = *pPathObj->m_ColorState.GetStrokeColor();
     if (StrokeColor.m_pCS && StrokeColor.m_pCS->GetFamily() == PDFCS_PATTERN) {
       DrawPathWithPattern(pPathObj, pObj2Device, &StrokeColor, TRUE);
       bStroke = FALSE;
     }
   }
 }