Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: core/src/fxge/ge/fx_ge_device.cpp

Issue 1520063002: Get rid of most instance of 'foo == NULL' (Closed) Base URL: https://pdfium.googlesource.com/pdfium@bstr_isnull
Patch Set: self review Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "core/include/fxge/fx_ge.h" 7 #include "core/include/fxge/fx_ge.h"
8 8
9 CFX_RenderDevice::CFX_RenderDevice() { 9 CFX_RenderDevice::CFX_RenderDevice() {
10 m_pDeviceDriver = NULL; 10 m_pDeviceDriver = NULL;
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 if (FXGETFLAG_COLORTYPE(alpha_flag)) { 124 if (FXGETFLAG_COLORTYPE(alpha_flag)) {
125 fill_alpha = FXGETFLAG_ALPHA_FILL(alpha_flag); 125 fill_alpha = FXGETFLAG_ALPHA_FILL(alpha_flag);
126 stroke_alpha = FXGETFLAG_ALPHA_STROKE(alpha_flag); 126 stroke_alpha = FXGETFLAG_ALPHA_STROKE(alpha_flag);
127 } else { 127 } else {
128 fill_alpha = FXARGB_A(fill_color); 128 fill_alpha = FXARGB_A(fill_color);
129 stroke_alpha = FXARGB_A(stroke_color); 129 stroke_alpha = FXARGB_A(stroke_color);
130 } 130 }
131 if ((fill_mode & 3) == 0) { 131 if ((fill_mode & 3) == 0) {
132 fill_alpha = 0; 132 fill_alpha = 0;
133 } 133 }
134 if (pGraphState == NULL) { 134 if (!pGraphState) {
135 stroke_alpha = 0; 135 stroke_alpha = 0;
136 } 136 }
137 if (stroke_alpha == 0 && pPathData->GetPointCount() == 2) { 137 if (stroke_alpha == 0 && pPathData->GetPointCount() == 2) {
138 FX_PATHPOINT* pPoints = pPathData->GetPoints(); 138 FX_PATHPOINT* pPoints = pPathData->GetPoints();
139 FX_FLOAT x1, x2, y1, y2; 139 FX_FLOAT x1, x2, y1, y2;
140 if (pObject2Device) { 140 if (pObject2Device) {
141 pObject2Device->Transform(pPoints[0].m_PointX, pPoints[0].m_PointY, x1, 141 pObject2Device->Transform(pPoints[0].m_PointX, pPoints[0].m_PointY, x1,
142 y1); 142 y1);
143 pObject2Device->Transform(pPoints[1].m_PointX, pPoints[1].m_PointY, x2, 143 pObject2Device->Transform(pPoints[1].m_PointX, pPoints[1].m_PointY, x2,
144 y2); 144 y2);
(...skipping 321 matching lines...) Expand 10 before | Expand all | Expand 10 after
466 return m_pDeviceDriver->StartDIBits(pBitmap, bitmap_alpha, argb, pMatrix, 466 return m_pDeviceDriver->StartDIBits(pBitmap, bitmap_alpha, argb, pMatrix,
467 flags, handle, alpha_flag, pIccTransform, 467 flags, handle, alpha_flag, pIccTransform,
468 blend_mode); 468 blend_mode);
469 } 469 }
470 FX_BOOL CFX_RenderDevice::ContinueDIBits(void* handle, IFX_Pause* pPause) { 470 FX_BOOL CFX_RenderDevice::ContinueDIBits(void* handle, IFX_Pause* pPause) {
471 return m_pDeviceDriver->ContinueDIBits(handle, pPause); 471 return m_pDeviceDriver->ContinueDIBits(handle, pPause);
472 } 472 }
473 void CFX_RenderDevice::CancelDIBits(void* handle) { 473 void CFX_RenderDevice::CancelDIBits(void* handle) {
474 m_pDeviceDriver->CancelDIBits(handle); 474 m_pDeviceDriver->CancelDIBits(handle);
475 } 475 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698