Get rid of most instance of 'foo == NULL'

core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/include/fpdfapi/fpdf_parser.h"
 
 #include "core/include/fxcrt/fx_string.h"
 
@@ skipping 565 matching lines @@
   while (pos) {
     if (CPDF_Object* value = static_cast<CPDF_Object*>(m_Map.GetNextValue(pos)))
       value->Release();
   }
 }
 FX_POSITION CPDF_Dictionary::GetStartPos() const {
   return m_Map.GetStartPosition();
 }
 CPDF_Object* CPDF_Dictionary::GetNextElement(FX_POSITION& pos,
                                              CFX_ByteString& key) const {
-  if (pos == NULL) {
+  if (!pos) {
     return NULL;
   }
   CPDF_Object* p;
   m_Map.GetNextAssoc(pos, key, (void*&)p);
   return p;
 }
 CPDF_Object* CPDF_Dictionary::GetElement(const CFX_ByteStringC& key) const {
   CPDF_Object* p = NULL;
   m_Map.Lookup(key, (void*&)p);
   return p;
@@ skipping 133 matching lines @@
 }
 
 void CPDF_Dictionary::AddValue(const CFX_ByteStringC& key, CPDF_Object* pObj) {
   ASSERT(m_Type == PDFOBJ_DICTIONARY);
   m_Map.AddValue(key, pObj);
 }
 void CPDF_Dictionary::RemoveAt(const CFX_ByteStringC& key) {
   ASSERT(m_Type == PDFOBJ_DICTIONARY);
   CPDF_Object* p = NULL;
   m_Map.Lookup(key, (void*&)p);
-  if (p == NULL) {
+  if (!p) {
     return;
   }
   p->Release();
   m_Map.RemoveKey(key);
 }
 void CPDF_Dictionary::ReplaceKey(const CFX_ByteStringC& oldkey,
                                  const CFX_ByteStringC& newkey) {
   ASSERT(m_Type == PDFOBJ_DICTIONARY);
   CPDF_Object* p = NULL;
   m_Map.Lookup(oldkey, (void*&)p);
-  if (p == NULL) {
+  if (!p) {
     return;
   }
   m_Map.RemoveKey(oldkey);
   m_Map.SetAt(newkey, p);
 }
 FX_BOOL CPDF_Dictionary::Identical(CPDF_Dictionary* pOther) const {
-  if (pOther == NULL) {
+  if (!pOther) {
     return FALSE;
   }
   if (m_Map.GetCount() != pOther->m_Map.GetCount()) {
     return FALSE;
   }
   FX_POSITION pos = m_Map.GetStartPosition();
   while (pos) {
     CFX_ByteString key;
     void* value;
     m_Map.GetNextAssoc(pos, key, value);
@@ skipping 380 matching lines @@
   if (!m_IndirectObjs.Lookup((void*)(uintptr_t)objnum, value))
     return;
   CPDF_Object* pValue = static_cast<CPDF_Object*>(value);
   if (pValue->GetObjNum() == -1)
     return;
   pValue->Destroy();
   m_IndirectObjs.RemoveKey((void*)(uintptr_t)objnum);
 }
 void CPDF_IndirectObjects::InsertIndirectObject(FX_DWORD objnum,
                                                 CPDF_Object* pObj) {
-  if (objnum == 0 || pObj == NULL) {
+  if (objnum == 0 || !pObj) {
     return;
   }
   void* value = NULL;
   if (m_IndirectObjs.Lookup((void*)(uintptr_t)objnum, value)) {
     if (value) {
       CPDF_Object* pValue = static_cast<CPDF_Object*>(value);
       if (pObj->GetGenNum() <= pValue->GetGenNum())
         return;
       pValue->Destroy();
     }
   }
   pObj->m_ObjNum = objnum;
   m_IndirectObjs.SetAt((void*)(uintptr_t)objnum, pObj);
   if (m_LastObjNum < objnum) {
     m_LastObjNum = objnum;
   }
 }
 FX_DWORD CPDF_IndirectObjects::GetLastObjNum() const {
   return m_LastObjNum;
 }