Get rid of most instance of 'foo == NULL'

core/src/fxge/ge/fx_ge_text.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/include/fxge/fx_ge.h"
 #include "core/include/fxge/fx_freetype.h"
 #include "core/include/fxcodec/fx_codec.h"
 #include "text_int.h"
@@ skipping 33 matching lines @@
 FX_RECT FXGE_GetGlyphsBBox(FXTEXT_GLYPHPOS* pGlyphAndPos,
                            int nChars,
                            int anti_alias,
                            FX_FLOAT retinaScaleX,
                            FX_FLOAT retinaScaleY) {
   FX_RECT rect(0, 0, 0, 0);
   FX_BOOL bStarted = FALSE;
   for (int iChar = 0; iChar < nChars; iChar++) {
     FXTEXT_GLYPHPOS& glyph = pGlyphAndPos[iChar];
     const CFX_GlyphBitmap* pGlyph = glyph.m_pGlyph;
-    if (pGlyph == NULL) {
+    if (!pGlyph) {
       continue;
     }
     int char_left = glyph.m_OriginX + pGlyph->m_Left;
     int char_width = (int)(pGlyph->m_Bitmap.GetWidth() / retinaScaleX);
     if (anti_alias == FXFT_RENDER_MODE_LCD) {
       char_width /= 3;
     }
     int char_right = char_left + char_width;
     int char_top = glyph.m_OriginY - pGlyph->m_Top;
     int char_bottom =
@@ skipping 69 matching lines @@
     228, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 239, 240,
     241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 250, 251, 252, 253, 254,
     255,
 };
 #define ADJUST_ALPHA(background, foreground, src_alpha, text_flags, a) \
   src_alpha = g_TextGammaAdjust[(uint8_t)src_alpha];
 void _Color2Argb(FX_ARGB& argb,
                  FX_DWORD color,
                  int alpha_flag,
                  void* pIccTransform) {
-  if (pIccTransform == NULL && !FXGETFLAG_COLORTYPE(alpha_flag)) {
+  if (!pIccTransform && !FXGETFLAG_COLORTYPE(alpha_flag)) {
     argb = color;
     return;
   }
   if (!CFX_GEModule::Get()->GetCodecModule() ||
       !CFX_GEModule::Get()->GetCodecModule()->GetIccModule()) {
     pIccTransform = NULL;
   }
   uint8_t bgra[4];
   if (pIccTransform) {
     ICodec_IccModule* pIccModule =
@@ skipping 81 matching lines @@
       return DrawTextPath(nChars, pCharPos, pFont, pCache, font_size,
                           pText2Device, NULL, NULL, fill_color, 0, NULL,
                           nPathFlags, alpha_flag, pIccTransform);
     }
   }
   int anti_alias = FXFT_RENDER_MODE_MONO;
   FX_BOOL bNormal = FALSE;
   if ((text_flags & FXTEXT_NOSMOOTH) == 0) {
     if (m_DeviceClass == FXDC_DISPLAY && m_bpp > 1) {
       FX_BOOL bClearType;
-      if (pFont->GetFace() == NULL &&
+      if (!pFont->GetFace() &&
           !(pFont->GetSubstFont()->m_SubstFlags & FXFONT_SUBST_CLEARTYPE)) {
         bClearType = FALSE;
       } else {
         bClearType = text_flags & FXTEXT_CLEARTYPE;
       }
       if ((m_RenderCaps & (FXRC_ALPHA_OUTPUT | FXRC_CMYK_OUTPUT))) {
         anti_alias = FXFT_RENDER_MODE_LCD;
         bNormal = TRUE;
       } else if (m_bpp < 16) {
         anti_alias = FXFT_RENDER_MODE_NORMAL;
       } else {
         if (bClearType == FALSE) {
           anti_alias = FXFT_RENDER_MODE_LCD;
           bNormal = TRUE;
         } else {
           anti_alias = FXFT_RENDER_MODE_LCD;
         }
       }
     }
   }
-  if (pCache == NULL) {
+  if (!pCache) {
     pCache = CFX_GEModule::Get()->GetFontCache();
   }
   CFX_FaceCache* pFaceCache = pCache->GetCachedFace(pFont);
   FX_FONTCACHE_DEFINE(pCache, pFont);
   FXTEXT_GLYPHPOS* pGlyphAndPos = FX_Alloc(FXTEXT_GLYPHPOS, nChars);
   int iChar;
   deviceCtm = char2device;
   CFX_AffineMatrix matrixCTM = GetCTM();
   FX_FLOAT scale_x = FXSYS_fabs(matrixCTM.a);
   FX_FLOAT scale_y = FXSYS_fabs(matrixCTM.d);
@@ skipping 50 matching lines @@
   int pixel_top = FXSYS_round(bmp_rect.top * scale_y);
   if (anti_alias == FXFT_RENDER_MODE_MONO) {
     CFX_DIBitmap bitmap;
     if (!bitmap.Create(pixel_width, pixel_height, FXDIB_1bppMask)) {
       FX_Free(pGlyphAndPos);
       return FALSE;
     }
     bitmap.Clear(0);
     for (iChar = 0; iChar < nChars; iChar++) {
       FXTEXT_GLYPHPOS& glyph = pGlyphAndPos[iChar];
-      if (glyph.m_pGlyph == NULL) {
+      if (!glyph.m_pGlyph) {
         continue;
       }
       const CFX_DIBitmap* pGlyph = &glyph.m_pGlyph->m_Bitmap;
       bitmap.TransferBitmap(
           glyph.m_OriginX + glyph.m_pGlyph->m_Left - pixel_left,
           glyph.m_OriginY - glyph.m_pGlyph->m_Top - pixel_top,
           pGlyph->GetWidth(), pGlyph->GetHeight(), pGlyph, 0, 0);
     }
     FX_Free(pGlyphAndPos);
     return SetBitMask(&bitmap, bmp_rect.left, bmp_rect.top, fill_color);
@@ skipping 29 matching lines @@
   int a, r, g, b;
   if (anti_alias == FXFT_RENDER_MODE_LCD) {
     _Color2Argb(fill_color, fill_color, alpha_flag | (1 << 24), pIccTransform);
     ArgbDecode(fill_color, a, r, g, b);
     r = FX_GAMMA(r);
     g = FX_GAMMA(g);
     b = FX_GAMMA(b);
   }
   for (iChar = 0; iChar < nChars; iChar++) {
     FXTEXT_GLYPHPOS& glyph = pGlyphAndPos[iChar];
-    if (glyph.m_pGlyph == NULL) {
+    if (!glyph.m_pGlyph) {
       continue;
     }
     const CFX_DIBitmap* pGlyph = &glyph.m_pGlyph->m_Bitmap;
     int left = glyph.m_OriginX + glyph.m_pGlyph->m_Left - pixel_left;
     int top = glyph.m_OriginY - glyph.m_pGlyph->m_Top - pixel_top;
     int ncols = pGlyph->GetWidth();
     int nrows = pGlyph->GetHeight();
     if (anti_alias == FXFT_RENDER_MODE_NORMAL) {
       if (!bitmap.CompositeMask(left, top, ncols, nrows, pGlyph, fill_color, 0,
                                 0, FXDIB_BLEND_NORMAL, NULL, FALSE, alpha_flag,
@@ skipping 712 matching lines @@
                                        const CFX_AffineMatrix* pText2User,
                                        const CFX_AffineMatrix* pUser2Device,
                                        const CFX_GraphStateData* pGraphState,
                                        FX_DWORD fill_color,
                                        FX_ARGB stroke_color,
                                        CFX_PathData* pClippingPath,
                                        int nFlag,
                                        int alpha_flag,
                                        void* pIccTransform,
                                        int blend_type) {
-  if (pCache == NULL) {
+  if (!pCache) {
     pCache = CFX_GEModule::Get()->GetFontCache();
   }
   CFX_FaceCache* pFaceCache = pCache->GetCachedFace(pFont);
   FX_FONTCACHE_DEFINE(pCache, pFont);
   for (int iChar = 0; iChar < nChars; iChar++) {
     const FXTEXT_CHARPOS& charpos = pCharPos[iChar];
     CFX_AffineMatrix matrix;
     if (charpos.m_bGlyphAdjust)
       matrix.Set(charpos.m_AdjustMatrix[0], charpos.m_AdjustMatrix[1],
                  charpos.m_AdjustMatrix[2], charpos.m_AdjustMatrix[3], 0, 0);
     matrix.Concat(font_size, 0, 0, font_size, charpos.m_OriginX,
                   charpos.m_OriginY);
     const CFX_PathData* pPath = pFaceCache->LoadGlyphPath(
         pFont, charpos.m_GlyphIndex, charpos.m_FontCharWidth);
-    if (pPath == NULL) {
+    if (!pPath) {
       continue;
     }
     matrix.Concat(*pText2User);
     CFX_PathData TransformedPath(*pPath);
     TransformedPath.Transform(&matrix);
     FX_BOOL bHasAlpha = FXGETFLAG_COLORTYPE(alpha_flag)
                             ? (FXGETFLAG_ALPHA_FILL(alpha_flag) ||
                                FXGETFLAG_ALPHA_STROKE(alpha_flag))
                             : (fill_color || stroke_color);
     if (bHasAlpha) {
@@ skipping 119 matching lines @@
   } else {
     pSizeCache = it->second;
   }
   CFX_GlyphBitmap* pGlyphBitmap = NULL;
   if (pSizeCache->m_GlyphMap.Lookup((void*)(uintptr_t)glyph_index,
                                     (void*&)pGlyphBitmap)) {
     return pGlyphBitmap;
   }
   pGlyphBitmap = RenderGlyph(pFont, glyph_index, bFontStyle, pMatrix,
                              dest_width, anti_alias);
-  if (pGlyphBitmap == NULL) {
+  if (!pGlyphBitmap) {
     return NULL;
   }
   pSizeCache->m_GlyphMap.SetAt((void*)(uintptr_t)glyph_index, pGlyphBitmap);
   return pGlyphBitmap;
 }
 const CFX_GlyphBitmap* CFX_FaceCache::LoadGlyphBitmap(
     CFX_Font* pFont,
     FX_DWORD glyph_index,
     FX_BOOL bFontStyle,
     const CFX_AffineMatrix* pMatrix,
@@ skipping 94 matching lines @@
   while (pos) {
     m_GlyphMap.GetNextAssoc(pos, Key, (void*&)pGlyphBitmap);
     delete pGlyphBitmap;
   }
   m_GlyphMap.RemoveAll();
 }
 #define CONTRAST_RAMP_STEP 1
 void CFX_Font::AdjustMMParams(int glyph_index, int dest_width, int weight) {
   FXFT_MM_Var pMasters = NULL;
   FXFT_Get_MM_Var(m_Face, &pMasters);
-  if (pMasters == NULL) {
+  if (!pMasters) {
     return;
   }
   long coords[2];
   if (weight == 0) {
     coords[0] = FXFT_Get_MM_Axis_Def(FXFT_Get_MM_Axis(pMasters, 0)) / 65536;
   } else {
     coords[0] = weight;
   }
   if (dest_width == 0) {
     coords[1] = FXFT_Get_MM_Axis_Def(FXFT_Get_MM_Axis(pMasters, 1)) / 65536;
@@ skipping 112 matching lines @@
       *pDstRow++ = (uint8_t)temp;
     }
   }
 }
 CFX_GlyphBitmap* CFX_FaceCache::RenderGlyph(CFX_Font* pFont,
                                             FX_DWORD glyph_index,
                                             FX_BOOL bFontStyle,
                                             const CFX_AffineMatrix* pMatrix,
                                             int dest_width,
                                             int anti_alias) {
-  if (m_Face == NULL) {
+  if (!m_Face) {
     return NULL;
   }
   FXFT_Matrix ft_matrix;
   ft_matrix.xx = (signed long)(pMatrix->GetA() / 64 * 65536);
   ft_matrix.xy = (signed long)(pMatrix->GetC() / 64 * 65536);
   ft_matrix.yx = (signed long)(pMatrix->GetB() / 64 * 65536);
   ft_matrix.yy = (signed long)(pMatrix->GetD() / 64 * 65536);
   FX_BOOL bUseCJKSubFont = FALSE;
   const CFX_SubstFont* pSubstFont = pFont->GetSubstFont();
   if (pSubstFont) {
@@ skipping 111 matching lines @@
                       dest_pitch);
       _GammaAdjust(pDestBuf, bmwidth, bmheight, dest_pitch,
                    CFX_GEModule::Get()->GetTextGammaTable());
     }
   }
   return pGlyphBitmap;
 }
 const CFX_PathData* CFX_FaceCache::LoadGlyphPath(CFX_Font* pFont,
                                                  FX_DWORD glyph_index,
                                                  int dest_width) {
-  if (m_Face == NULL || glyph_index == (FX_DWORD)-1) {
+  if (!m_Face || glyph_index == (FX_DWORD)-1) {
     return NULL;
   }
   CFX_PathData* pGlyphPath = NULL;
   void* key;
   if (pFont->GetSubstFont()) {
     key = (void*)(uintptr_t)(
         glyph_index + ((pFont->GetSubstFont()->m_Weight / 16) << 15) +
         ((pFont->GetSubstFont()->m_ItalicAngle / 2) << 21) +
         ((dest_width / 16) << 25) + (pFont->IsVertical() << 31));
   } else {
@@ skipping 126 matching lines @@
         to->y / param->m_CoordUnit;
     param->m_pPoints[param->m_PointCount + 2].m_Flag = FXPT_BEZIERTO;
     param->m_CurX = to->x;
     param->m_CurY = to->y;
   }
   param->m_PointCount += 3;
   return 0;
 }
 };
 CFX_PathData* CFX_Font::LoadGlyphPath(FX_DWORD glyph_index, int dest_width) {
-  if (m_Face == NULL) {
+  if (!m_Face) {
     return NULL;
   }
   FXFT_Set_Pixel_Sizes(m_Face, 0, 64);
   FXFT_Matrix ft_matrix = {65536, 0, 0, 65536};
   if (m_pSubstFont) {
     if (m_pSubstFont->m_ItalicAngle) {
       int skew = m_pSubstFont->m_ItalicAngle;
       skew = skew <= -ANGLESKEW_ARRAY_SIZE ? -58 : -g_AngleSkew[-skew];
       if (m_bVertical) {
         ft_matrix.yx += ft_matrix.yy * skew / 100;
@@ skipping 59 matching lines @@
 void _CFX_UniqueKeyGen::Generate(int count, ...) {
   va_list argList;
   va_start(argList, count);
   for (int i = 0; i < count; i++) {
     int p = va_arg(argList, int);
     ((FX_DWORD*)m_Key)[i] = p;
   }
   va_end(argList);
   m_KeyLen = count * sizeof(FX_DWORD);
 }