Get rid of most instance of 'foo == NULL'

core/src/fxcrt/fx_basic_util.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/include/fxcrt/fx_basic.h"
 #include "core/include/fxcrt/fx_ext.h"
 
 #include <cctype>
 
 #if _FXM_PLATFORM_ != _FXM_PLATFORM_WINDOWS_
 #include <sys/types.h>
 #include <dirent.h>
 #else
 #include <direct.h>
 #endif
 
 CFX_PrivateData::~CFX_PrivateData() {
   ClearAll();
 }
 void FX_PRIVATEDATA::FreeData() {
-  if (m_pData == NULL) {
+  if (!m_pData) {
     return;
   }
   if (m_bSelfDestruct) {
     delete (CFX_DestructObject*)m_pData;
   } else if (m_pCallback) {
     m_pCallback(m_pData);
   }
 }
 void CFX_PrivateData::AddData(void* pModuleId,
                               void* pData,
                               PD_CALLBACK_FREEDATA callback,
                               FX_BOOL bSelfDestruct) {
-  if (pModuleId == NULL) {
+  if (!pModuleId) {
     return;
   }
   FX_PRIVATEDATA* pList = m_DataList.GetData();
   int count = m_DataList.GetSize();
   for (int i = 0; i < count; i++) {
     if (pList[i].m_pModuleId == pModuleId) {
       pList[i].FreeData();
       pList[i].m_pData = pData;
       pList[i].m_pCallback = callback;
       return;
     }
   }
   FX_PRIVATEDATA data = {pModuleId, pData, callback, bSelfDestruct};
   m_DataList.Add(data);
 }
 void CFX_PrivateData::SetPrivateData(void* pModuleId,
                                      void* pData,
                                      PD_CALLBACK_FREEDATA callback) {
   AddData(pModuleId, pData, callback, FALSE);
 }
 void CFX_PrivateData::SetPrivateObj(void* pModuleId, CFX_DestructObject* pObj) {
   AddData(pModuleId, pObj, NULL, TRUE);
 }
 FX_BOOL CFX_PrivateData::RemovePrivateData(void* pModuleId) {
-  if (pModuleId == NULL) {
+  if (!pModuleId) {
     return FALSE;
   }
   FX_PRIVATEDATA* pList = m_DataList.GetData();
   int count = m_DataList.GetSize();
   for (int i = 0; i < count; i++) {
     if (pList[i].m_pModuleId == pModuleId) {
       m_DataList.RemoveAt(i);
       return TRUE;
     }
   }
   return FALSE;
 }
 void* CFX_PrivateData::GetPrivateData(void* pModuleId) {
-  if (pModuleId == NULL) {
+  if (!pModuleId) {
     return NULL;
   }
   FX_PRIVATEDATA* pList = m_DataList.GetData();
   int count = m_DataList.GetSize();
   for (int i = 0; i < count; i++) {
     if (pList[i].m_pModuleId == pModuleId) {
       return pList[i].m_pData;
     }
   }
   return NULL;
 }
 void CFX_PrivateData::ClearAll() {
   FX_PRIVATEDATA* pList = m_DataList.GetData();
   int count = m_DataList.GetSize();
   for (int i = 0; i < count; i++) {
     pList[i].FreeData();
   }
   m_DataList.RemoveAll();
 }
 void FX_atonum(const CFX_ByteStringC& strc, FX_BOOL& bInteger, void* pData) {
-  if (FXSYS_memchr(strc.GetPtr(), '.', strc.GetLength()) == NULL) {
+  if (!FXSYS_memchr(strc.GetPtr(), '.', strc.GetLength())) {
     bInteger = TRUE;
     int cc = 0, integer = 0;
     const FX_CHAR* str = strc.GetCStr();
     int len = strc.GetLength();
     FX_BOOL bNegative = FALSE;
     if (str[0] == '+') {
       cc++;
     } else if (str[0] == '-') {
       bNegative = TRUE;
       cc++;
@@ skipping 143 matching lines @@
   pData->m_bEnd = FALSE;
   return pData;
 #else
   DIR* dir = opendir(CFX_ByteString::FromUnicode(path));
   return dir;
 #endif
 }
 FX_BOOL FX_GetNextFile(void* handle,
                        CFX_ByteString& filename,
                        FX_BOOL& bFolder) {
-  if (handle == NULL) {
+  if (!handle) {
     return FALSE;
   }
 #if _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_
 #ifndef _WIN32_WCE
   CFindFileDataA* pData = (CFindFileDataA*)handle;
   if (pData->m_bEnd) {
     return FALSE;
   }
   filename = pData->m_FindData.cFileName;
   bFolder = pData->m_FindData.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY;
@@ skipping 11 matching lines @@
   if (!FindNextFileW(pData->m_Handle, &pData->m_FindData)) {
     pData->m_bEnd = TRUE;
   }
   return TRUE;
 #endif
 #elif defined(__native_client__)
   abort();
   return FALSE;
 #else
   struct dirent* de = readdir((DIR*)handle);
-  if (de == NULL) {
+  if (!de) {
     return FALSE;
   }
   filename = de->d_name;
   bFolder = de->d_type == DT_DIR;
   return TRUE;
 #endif
 }
 FX_BOOL FX_GetNextFile(void* handle,
                        CFX_WideString& filename,
                        FX_BOOL& bFolder) {
-  if (handle == NULL) {
+  if (!handle) {
     return FALSE;
   }
 #if _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_
   CFindFileDataW* pData = (CFindFileDataW*)handle;
   if (pData->m_bEnd) {
     return FALSE;
   }
   filename = pData->m_FindData.cFileName;
   bFolder = pData->m_FindData.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY;
   if (!FindNextFileW(pData->m_Handle, &pData->m_FindData)) {
     pData->m_bEnd = TRUE;
   }
   return TRUE;
 #elif defined(__native_client__)
   abort();
   return FALSE;
 #else
   struct dirent* de = readdir((DIR*)handle);
-  if (de == NULL) {
+  if (!de) {
     return FALSE;
   }
   filename = CFX_WideString::FromLocal(de->d_name);
   bFolder = de->d_type == DT_DIR;
   return TRUE;
 #endif
 }
 void FX_CloseFolder(void* handle) {
-  if (handle == NULL) {
+  if (!handle) {
     return;
   }
 #if _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_
   CFindFileData* pData = (CFindFileData*)handle;
   FindClose(pData->m_Handle);
   delete pData;
 #else
   closedir((DIR*)handle);
 #endif
 }
@@ skipping 24 matching lines @@
       d * m.b + e * m.e + f * m.h, d * m.c + e * m.f + f * m.i,
       g * m.a + h * m.d + i * m.g, g * m.b + h * m.e + i * m.h,
       g * m.c + h * m.f + i * m.i);
 }
 
 CFX_Vector_3by1 CFX_Matrix_3by3::TransformVector(const CFX_Vector_3by1& v) {
   return CFX_Vector_3by1(a * v.a + b * v.b + c * v.c,
                          d * v.a + e * v.b + f * v.c,
                          g * v.a + h * v.b + i * v.c);
 }