Get rid of most instance of 'foo == NULL'

core/src/fpdfdoc/doc_ocg.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/include/fpdfdoc/fpdf_doc.h"
 
 static int32_t FPDFDOC_OCG_FindGroup(const CPDF_Object* pObject,
                                      const CPDF_Dictionary* pGroupDict) {
   if (!pObject || !pGroupDict)
     return -1;
 
   if (const CPDF_Array* pArray = pObject->AsArray()) {
     FX_DWORD dwCount = pArray->GetCount();
     for (FX_DWORD i = 0; i < dwCount; i++) {
       if (pArray->GetDict(i) == pGroupDict)
         return i;
     }
     return -1;
   }
   return pObject->GetDict() == pGroupDict ? 0 : -1;
 }
 static FX_BOOL FPDFDOC_OCG_HasIntent(const CPDF_Dictionary* pDict,
                                      const CFX_ByteStringC& csElement,
                                      const CFX_ByteStringC& csDef = "") {
   FXSYS_assert(pDict);
   CPDF_Object* pIntent = pDict->GetElementValue("Intent");
-  if (pIntent == NULL) {
+  if (!pIntent) {
     return csElement == csDef;
   }
   CFX_ByteString bsIntent;
   if (CPDF_Array* pArray = pIntent->AsArray()) {
     FX_DWORD dwCount = pArray->GetCount();
     for (FX_DWORD i = 0; i < dwCount; i++) {
       bsIntent = pArray->GetString(i);
       if (bsIntent == "All" || bsIntent == csElement)
         return TRUE;
     }
@@ skipping 143 matching lines @@
   m_OCGStates[pOCGDict] = bState;
   return bState;
 }
 
 FX_BOOL CPDF_OCContext::GetOCGVE(CPDF_Array* pExpression,
                                  FX_BOOL bFromConfig,
                                  int nLevel) {
   if (nLevel > 32) {
     return FALSE;
   }
-  if (pExpression == NULL) {
+  if (!pExpression) {
     return FALSE;
   }
   int32_t iCount = pExpression->GetCount();
   CPDF_Object* pOCGObj;
   CFX_ByteString csOperator = pExpression->GetString(0);
   if (csOperator == "Not") {
     pOCGObj = pExpression->GetElementValue(1);
     if (!pOCGObj)
       return FALSE;
     if (CPDF_Dictionary* pDict = pOCGObj->AsDictionary())
       return !(bFromConfig ? LoadOCGState(pDict) : GetOCGVisible(pDict));
     if (CPDF_Array* pArray = pOCGObj->AsArray())
       return !GetOCGVE(pArray, bFromConfig, nLevel + 1);
     return FALSE;
   }
   if (csOperator == "Or" || csOperator == "And") {
     FX_BOOL bValue = FALSE;
     for (int32_t i = 1; i < iCount; i++) {
       pOCGObj = pExpression->GetElementValue(1);
-      if (pOCGObj == NULL) {
+      if (!pOCGObj) {
         continue;
       }
       FX_BOOL bItem = FALSE;
       if (CPDF_Dictionary* pDict = pOCGObj->AsDictionary())
         bItem = bFromConfig ? LoadOCGState(pDict) : GetOCGVisible(pDict);
       else if (CPDF_Array* pArray = pOCGObj->AsArray())
         bItem = GetOCGVE(pArray, bFromConfig, nLevel + 1);
 
       if (i == 1) {
         bValue = bItem;
@@ skipping 51 matching lines @@
   }
   CFX_ByteString csType = pOCGDict->GetString("Type", "OCG");
   if (csType == "OCG") {
     return GetOCGVisible(pOCGDict);
   }
   return LoadOCMDState(pOCGDict, FALSE);
 }
 void CPDF_OCContext::ResetOCContext() {
   m_OCGStates.clear();
 }