Get rid of most instance of 'foo == NULL'

core/include/fxcrt/fx_basic.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef CORE_INCLUDE_FXCRT_FX_BASIC_H_
 #define CORE_INCLUDE_FXCRT_FX_BASIC_H_
 
 #include "fx_memory.h"
@@ skipping 860 matching lines @@
       m_pObject->m_RefCount--;
       if (m_pObject->m_RefCount <= 0) {
         delete m_pObject;
       }
     }
     m_pObject = ref.m_pObject;
   }
 
   void operator=(void* p) {
     FXSYS_assert(p == 0);
-    if (m_pObject == NULL) {
+    if (!m_pObject) {
       return;
     }
     m_pObject->m_RefCount--;
     if (m_pObject->m_RefCount <= 0) {
       delete m_pObject;
     }
     m_pObject = NULL;
   }
 
   const ObjClass* GetObject() const { return m_pObject; }
 
   operator const ObjClass*() const { return m_pObject; }
 
-  FX_BOOL IsNull() const { return m_pObject == NULL; }
+  FX_BOOL IsNull() const { return !m_pObject; }
 
-  FX_BOOL NotNull() const { return m_pObject != NULL; }
+  FX_BOOL NotNull() const { return !IsNull(); }

[Lei Zhang, 2015/12/12 02:31:44]

or leave it as is?

 
   ObjClass* GetModify() {
-    if (m_pObject == NULL) {
+    if (!m_pObject) {
       m_pObject = new CountedObj;
       m_pObject->m_RefCount = 1;
     } else if (m_pObject->m_RefCount > 1) {
       m_pObject->m_RefCount--;
       CountedObj* pOldObject = m_pObject;
       m_pObject = new CountedObj(*pOldObject);
       m_pObject->m_RefCount = 1;
     }
     return m_pObject;
   }
 
   void SetNull() {
-    if (m_pObject == NULL) {
+    if (!m_pObject) {
       return;
     }
     m_pObject->m_RefCount--;
     if (m_pObject->m_RefCount <= 0) {
       delete m_pObject;
     }
     m_pObject = NULL;
   }
 
   FX_BOOL operator==(const Ref& ref) const {
@@ skipping 211 matching lines @@
   FX_FLOAT c;
   FX_FLOAT d;
   FX_FLOAT e;
   FX_FLOAT f;
   FX_FLOAT g;
   FX_FLOAT h;
   FX_FLOAT i;
 };
 
 #endif  // CORE_INCLUDE_FXCRT_FX_BASIC_H_