Grab bag of clang fixes for Windows code

sandbox/win/src/policy_params.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SANDBOX_SRC_POLICY_PARAMS_H__
 #define SANDBOX_SRC_POLICY_PARAMS_H__
 
 #include "sandbox/win/src/policy_engine_params.h"
 
 namespace sandbox {
@@ skipping 14 matching lines @@
   POLPARAM(ACCESS)
   POLPARAM(OPTIONS)
 POLPARAMS_END(OpenFile)
 
 // Policy parameter for name-based policies.
 POLPARAMS_BEGIN(FileName)
   POLPARAM(NAME)
   POLPARAM(BROKER)   // TRUE if called from the broker.
 POLPARAMS_END(FileName)
 
-COMPILE_ASSERT(OpenFile::NAME == FileName::NAME, to_simplify_fs_policies);
-COMPILE_ASSERT(OpenFile::BROKER == FileName::BROKER, to_simplify_fs_policies);
+COMPILE_ASSERT(OpenFile::NAME == (int)FileName::NAME, to_simplify_fs_policies);
+COMPILE_ASSERT(OpenFile::BROKER == (int)FileName::BROKER,

[mmenke, 2013/05/16 21:58:46]

C-style casts violate Google style guide.

+               to_simplify_fs_policies);
 
 // Policy parameter for name-based policies.
 POLPARAMS_BEGIN(NameBased)
   POLPARAM(NAME)
 POLPARAMS_END(NameBased)
 
 // Policy parameters for open event.
 POLPARAMS_BEGIN(OpenEventParams)
   POLPARAM(NAME)
   POLPARAM(ACCESS)
 POLPARAMS_END(OpenEventParams)
 
 // Policy Parameters for reg open / create.
 POLPARAMS_BEGIN(OpenKey)
   POLPARAM(NAME)
   POLPARAM(ACCESS)
 POLPARAMS_END(OpenKey)
 
 // Policy parameter for name-based policies.
 POLPARAMS_BEGIN(HandleTarget)
   POLPARAM(NAME)
   POLPARAM(TARGET)
 POLPARAMS_END(HandleTarget)
 
 
 }  // namespace sandbox
 
 #endif  // SANDBOX_SRC_POLICY_PARAMS_H__