Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1484)

Side by Side Diff: Source/core/rendering/RenderTableCol.cpp

Issue 151993004: Col width is not honored when dynamically updated and it would not make table narrower (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2009 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2009 Apple Inc. All rights reserved.
8 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 8 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 updateFromElement(); 44 updateFromElement();
45 } 45 }
46 46
47 void RenderTableCol::styleDidChange(StyleDifference diff, const RenderStyle* old Style) 47 void RenderTableCol::styleDidChange(StyleDifference diff, const RenderStyle* old Style)
48 { 48 {
49 RenderBox::styleDidChange(diff, oldStyle); 49 RenderBox::styleDidChange(diff, oldStyle);
50 50
51 // If border was changed, notify table. 51 // If border was changed, notify table.
52 if (parent()) { 52 if (parent()) {
53 RenderTable* table = this->table(); 53 RenderTable* table = this->table();
54 if (table && !table->selfNeedsLayout() && !table->normalChildNeedsLayout () && oldStyle && oldStyle->border() != style()->border()) 54 if (table && !table->selfNeedsLayout() && !table->normalChildNeedsLayout () && oldStyle && oldStyle->border() != style()->border()) {
55 table->invalidateCollapsedBorders(); 55 table->invalidateCollapsedBorders();
56 } else if (oldStyle && oldStyle->logicalWidth() != style()->logicalWidth ()) {
57 unsigned nEffCols = table->numEffCols();
58 unsigned currentColumn = 0;
59 RenderTableSection* section = 0;
60 for (RenderTableCol* column = table->firstColumn()->nextColumn(); co lumn; column = column->nextColumn()) {
61 if (this == column)
62 break;
63 currentColumn += column->span();
64 }
65 for (RenderObject* child = table->firstChild(); child; child = child ->nextSibling()) {
66 if (child->isTableSection()) {
67 section = toRenderTableSection(child);
68 break;
69 }
70 }
Julien - ping for review 2014/02/24 19:25:31 There is table->topSection() that will give you th
Gurpreet 2014/02/25 13:12:56 Done.
71 unsigned currentColSpan = currentColumn + span();
72 for (unsigned j = currentColumn; j < currentColSpan && currentColSpa n <= nEffCols; j++) {
73 for (unsigned i = 0; i < section->numRows(); i++) {
74 RenderTableCell* cell = section->primaryCellAt(i, j);
75 if (!cell)
76 continue;
77 cell->setPreferredLogicalWidthsDirty();
78 }
79 }
80 }
Julien - ping for review 2014/02/24 19:25:31 Again, you need to invalidate the whole column whi
Gurpreet 2014/02/25 13:12:56 Done.
56 } 81 }
57 } 82 }
58 83
59 void RenderTableCol::updateFromElement() 84 void RenderTableCol::updateFromElement()
60 { 85 {
61 unsigned oldSpan = m_span; 86 unsigned oldSpan = m_span;
62 Node* n = node(); 87 Node* n = node();
63 if (n && (n->hasTagName(colTag) || n->hasTagName(colgroupTag))) { 88 if (n && (n->hasTagName(colTag) || n->hasTagName(colgroupTag))) {
64 HTMLTableColElement* tc = toHTMLTableColElement(n); 89 HTMLTableColElement* tc = toHTMLTableColElement(n);
65 m_span = tc->span(); 90 m_span = tc->span();
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 return style()->borderStart(); 199 return style()->borderStart();
175 } 200 }
176 201
177 const BorderValue& RenderTableCol::borderAdjoiningCellAfter(const RenderTableCel l* cell) const 202 const BorderValue& RenderTableCol::borderAdjoiningCellAfter(const RenderTableCel l* cell) const
178 { 203 {
179 ASSERT_UNUSED(cell, table()->colElement(cell->col() - 1) == this); 204 ASSERT_UNUSED(cell, table()->colElement(cell->col() - 1) == this);
180 return style()->borderEnd(); 205 return style()->borderEnd();
181 } 206 }
182 207
183 } 208 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698