LayoutTests/fast/dom/HTMLTableColElement/resize-table-width-using-col-width.html - Issue 151993004: Col width is not honored when dynamically updated and it would not make table narrower

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/HTMLTableColElement/resize-table-width-using-col-width.html

Issue 151993004: Col width is not honored when dynamically updated and it would not make table narrower (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLTableColElement/resize-table-using-col-height-vertical-writing-mode-expected.txt ('k') | LayoutTests/fast/dom/HTMLTableColElement/resize-table-width-using-col-width-expected.txt » ('j') | Source/core/rendering/RenderTableCol.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <style>

	5 col {

	6 width: 200px;

	7 }

	8 td {

	9 background-color: #66f;

	10 height: 25px;

	11 }

	12 </style>

	13 <script type="text/javascript">

	14 function changeColWidthUsingWidth(){

	15 var col = document.getElementById('thecol');

	16 col.style.width="100px";

	17 window.checkLayout("td", document.getElementById("test-output")) ;

	18 }

	19 </script>

	20 <script src="../../../resources/check-layout.js"></script>

	21 </head>

	22 <body>

	23 Tests that the width of table cell changes on changing the colgroup widt h to new width.

	24 <table>

	25 <colgroup>

	26 <col id="thecol">

	27 </colgroup>

	28 <tbody>

	29 <tr>

	30 <td id="colWidth" data-expected-width="100"></td>

	31 </tr>

	32 </tbody>

	33 </table>

	34 <button onclick="changeColWidthUsingWidth();">Click me to test manually. The column should shrink to 100px.</button>
	Julien - ping for review 2014/02/14 18:18:37 It's awesome that you thought about manual testing It's awesome that you thought about manual testing! Couldn't we just make it automatic using the load event? If needed you can always force a layout by querying document.body.offsetTop Gurpreet 2014/02/17 09:40:43 The col width changes should be done on some manua Show quoted text On 2014/02/14 18:18:37, Julien Chaffraix - PST wrote: > It's awesome that you thought about manual testing! > > Couldn't we just make it automatic using the load event? If needed you can > always force a layout by querying document.body.offsetTop The col width changes should be done on some manual action or after some time so that initially the table layout is done with col width as 200px and then changed to 100px. I tried with onload event and setTimeout function as <script type="text/javascript"> function runTest() { setTimeout(function() { var col = document.getElementById('thecol'); col.style.width="100px"; window.checkLayout("td", document.getElementById("test-output")); }, 0); } </script> <body onload="runTest()"> But then the expected.txt file is not generated properly. window.checkLayout("td", document.getElementById("test-output")); doesnot run.
	35 <div id="test-output"></div>

	36 </body>

	37 <script>

	38 if (window.eventSender) {

	39 eventSender.mouseMoveTo(50, 75);

	40 eventSender.mouseDown();

	41 eventSender.mouseUp();

	42 }

	43 </script>

	44 </html>

OLD	NEW