Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 151993002: Probe whether MFPlat.dll is present on Windows systems. (Closed)

Created:
6 years, 10 months ago by scherkus (not reviewing)
Modified:
6 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org, ananta, Ami GONE FROM CHROMIUM
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Probe whether MFPlat.dll is present on Windows systems. Not all versions of Windows 7 and later ship with Media Foundation DLLs. Instead of crashing while attempting to delay load the DLL, preemptively load the library and fail gracefully if we're unable to do so. BUG=339678 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248586

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M content/common/gpu/media/dxva_video_decode_accelerator.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scherkus (not reviewing)
scottmg: PTAL fischman/ananta: FYI tested it out by changing the code to a nonsensical DLL ...
6 years, 10 months ago (2014-02-01 02:13:37 UTC) #1
scottmg
lgtm
6 years, 10 months ago (2014-02-01 03:10:28 UTC) #2
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 10 months ago (2014-02-03 19:27:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/151993002/1
6 years, 10 months ago (2014-02-03 19:28:51 UTC) #4
commit-bot: I haz the power
Change committed as 248586
6 years, 10 months ago (2014-02-03 22:05:18 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 22:05:22 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 22:05:29 UTC) #7
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698