Issue 15199008: Disable blending when there is an effect that reads the dst and draw state blend is 1,0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15199008: Disable blending when there is an effect that reads the dst and draw state blend is 1,0. (Closed)

Created:
7 years, 7 months ago by bsalomon

Modified:
7 years, 7 months ago

Reviewers:
jvanverth1, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Disable blending when there is an effect that reads the dst and draw state blend is 1,0. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=9147

Created: 7 years, 7 months ago

		Unified diffs	Side-by-side diffs	Stats (+9 lines, -2 lines)
	M	src/gpu/GrDrawState.cpp	View	1 chunk	+7 lines, -0 lines	0 comments
	M	src/gpu/gl/GrGLProgramDesc.cpp	View	1 chunk	+2 lines, -2 lines	0 comments

Total messages: 3 (0 generated)

bsalomon

This will cause GL-blending to be disabled, which in turn causes disable_coverage_aa_for_blend() to return false.

7 years, 7 months ago (2013-05-15 15:07:13 UTC) #1

bsalomon

7 years, 7 months ago (2013-05-15 17:53:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r9147 (presubmit successful).