chrome/browser/chromeos/login/helper.cc - Issue 1519883003: 1) Add basic configuration (network connection, language, keyboard layout, timezone) setup page. 2)…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/helper.cc

Issue 1519883003: 1) Add basic configuration (network connection, language, keyboard layout, timezone) setup page. 2)… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | chrome/browser/chromeos/login/screens/controller_pairing_screen.cc » ('j') | chrome/browser/chromeos/login/screens/host_pairing_screen.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/helper.cc

diff --git a/chrome/browser/chromeos/login/helper.cc b/chrome/browser/chromeos/login/helper.cc

index e60a789085d4ee57d9e63bbbd4945079c4d41120..56a3f549a63647fc0ab5b784aab1b9d169d69fba 100644

--- a/chrome/browser/chromeos/login/helper.cc

+++ b/chrome/browser/chromeos/login/helper.cc

@@ -170,6 +170,7 @@ void NetworkStateHelper::CreateAndConnectNetworkFromOnc(

base::DictionaryValue* toplevel_onc = nullptr;

if (!root || !root->GetAsDictionary(&toplevel_onc)) {

LOG(ERROR) << "Invalid JSON Dictionary: " << error;

+ error_callback.Run();

return;

}