Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4960)

Unified Diff: chrome/browser/chromeos/login/screens/network_screen.cc

Issue 1519883003: 1) Add basic configuration (network connection, language, keyboard layout, timezone) setup page. 2)… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix the i18n-content HTML format in the html files Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/screens/network_screen.cc
diff --git a/chrome/browser/chromeos/login/screens/network_screen.cc b/chrome/browser/chromeos/login/screens/network_screen.cc
index 8c25a17a0ae96857d20989f16ff7be02f12a09b0..8d83dc0461b7f92383d3f08ff014b64a835d06f0 100644
--- a/chrome/browser/chromeos/login/screens/network_screen.cc
+++ b/chrome/browser/chromeos/login/screens/network_screen.cc
@@ -229,11 +229,11 @@ void NetworkScreen::GetConnectedWifiNetwork(std::string* out_onc_spec) {
}
void NetworkScreen::CreateAndConnectNetworkFromOnc(
- const std::string& onc_spec) {
+ const std::string& onc_spec,
+ const base::Closure& success_callback,
+ const base::Closure& failed_callback) {
network_state_helper_->CreateAndConnectNetworkFromOnc(
- onc_spec, base::Bind(&base::DoNothing),
- base::Bind(&NetworkScreen::OnConnectNetworkFromOncFailed,
- base::Unretained(this)));
+ onc_spec, success_callback, failed_callback);
}
void NetworkScreen::AddObserver(Observer* observer) {
@@ -441,13 +441,4 @@ void NetworkScreen::OnSystemTimezoneChanged() {
GetContextEditor().SetString(kContextKeyTimezone, current_timezone_id);
}
-void NetworkScreen::OnConnectNetworkFromOncFailed() {
- if (!network_state_helper_->IsConnected() && view_) {
- // Show error bubble.
- view_->ShowError(l10n_util::GetStringFUTF16(
- IDS_NETWORK_SELECTION_ERROR,
- l10n_util::GetStringUTF16(IDS_SHORT_PRODUCT_OS_NAME)));
- }
-}
-
} // namespace chromeos
« no previous file with comments | « chrome/browser/chromeos/login/screens/network_screen.h ('k') | chrome/browser/chromeos/login/wizard_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698