1) Add basic configuration (network connection, language, keyboard layout, timezone) setup page. 2)…

1) Add basic configuration (network connection, language, keyboard layout, timezone) setup page.
2) Add network setup error page.
3) Format the i18n style in host-pairing-screen.html and controller-pairing-screen.html.

BUG=564370
Committed: https://crrev.com/1bc23b7f85b9d927c23a85458ce0e10e644a4b61
Cr-Commit-Position: refs/heads/master@{#365597}

[xdai1, 2015-12-12 01:23:16]

Patchset #1 (id:1) has been deleted

[xdai1, 2015-12-12 01:24:51]

The CQ bit was checked by xdai@chromium.org to run a CQ dry run

[xdai1, 2015-12-12 01:25:06]

Description was changed from

==========
1) Add basic configuration (network connection, language, keyboard layout,
timezone) setup page. 2) Add network setup error page.

BUG=564370
==========

to

==========
1) Add basic configuration (network connection, language, keyboard layout,
timezone) setup page. 
2) Add network setup error page.

BUG=564370
==========

[commit-bot: I haz the power, 2015-12-12 01:27:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1519883003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1519883003/20001

[xdai1, 2015-12-12 01:31:21]

xdai@chromium.org changed reviewers:
+ dzhioev@chromium.org

[xdai1, 2015-12-12 01:31:21]

Pasha, could you help review this CL? Thanks!

[xdai1, 2015-12-15 17:35:06]

On 2015/12/12 01:31:21, xdai1 wrote:
> Pasha, could you help review this CL? Thanks!

kindly ping?

[dzhioev (left Google), 2015-12-15 23:07:23]

https://codereview.chromium.org/1519883003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/host_pairing_screen.cc (right):

https://codereview.chromium.org/1519883003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/host_pairing_screen.cc:86: case
HostPairingController::STAGE_SETUP_NETWOKR_ERROR: {
s/NETWOKR/NETWORK/

https://codereview.chromium.org/1519883003/diff/40001/components/pairing/host...
File components/pairing/host_pairing_controller.h (right):

https://codereview.chromium.org/1519883003/diff/40001/components/pairing/host...
components/pairing/host_pairing_controller.h:77: virtual void ChangeStage(Stage
new_stage) = 0;
This method shouldn't be in a public interface. Changing the stage is a
responsibility of the controller. External code can only notify the controller
about events (e.g. network configuration failed, or update status changed) and
it's up to controller to decide which stage should go next.

[xdai1, 2015-12-16 01:49:57]

Patchset #3 (id:60001) has been deleted

[xdai1, 2015-12-16 01:51:13]

On 2015/12/15 23:07:23, dzhioev wrote:
>
https://codereview.chromium.org/1519883003/diff/40001/chrome/browser/chromeos...
> File chrome/browser/chromeos/login/screens/host_pairing_screen.cc (right):
> 
>
https://codereview.chromium.org/1519883003/diff/40001/chrome/browser/chromeos...
> chrome/browser/chromeos/login/screens/host_pairing_screen.cc:86: case
> HostPairingController::STAGE_SETUP_NETWOKR_ERROR: {
> s/NETWOKR/NETWORK/
> 
>
https://codereview.chromium.org/1519883003/diff/40001/components/pairing/host...
> File components/pairing/host_pairing_controller.h (right):
> 
>
https://codereview.chromium.org/1519883003/diff/40001/components/pairing/host...
> components/pairing/host_pairing_controller.h:77: virtual void
ChangeStage(Stage
> new_stage) = 0;
> This method shouldn't be in a public interface. Changing the stage is a
> responsibility of the controller. External code can only notify the controller
> about events (e.g. network configuration failed, or update status changed) and
> it's up to controller to decide which stage should go next.

Thanks for the review! Please take another look.

[dzhioev (left Google), 2015-12-16 02:01:36]

LGTM

[xdai1, 2015-12-16 02:02:15]

The CQ bit was checked by xdai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-16 02:05:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1519883003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1519883003/80001

[commit-bot: I haz the power, 2015-12-16 04:12:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 04:12:10]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xdai1, 2015-12-16 06:30:53]

The CQ bit was checked by xdai@chromium.org

[commit-bot: I haz the power, 2015-12-16 06:31:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1519883003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1519883003/80001

[commit-bot: I haz the power, 2015-12-16 06:39:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 06:39:48]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xdai1, 2015-12-16 18:47:21]

Patchset #4 (id:100001) has been deleted

[xdai1, 2015-12-16 18:48:28]

Description was changed from

==========
1) Add basic configuration (network connection, language, keyboard layout,
timezone) setup page. 
2) Add network setup error page.

BUG=564370
==========

to

==========
1) Add basic configuration (network connection, language, keyboard layout,
timezone) setup page. 
2) Add network setup error page.
3) Format the i18n style in host-pairing-screen.html and
controller-pairing-screen.html.

BUG=564370
==========

[xdai1, 2015-12-16 19:24:45]

Patchset #4 (id:120001) has been deleted

[xdai1, 2015-12-16 19:28:13]

The CQ bit was checked by xdai@chromium.org

[xdai1, 2015-12-16 19:28:13]

The patchset sent to the CQ was uploaded after l-g-t-m from dzhioev@chromium.org
Link to the patchset: https://codereview.chromium.org/1519883003/#ps140001
(title: "Fix the i18n-content HTML format in the html files")

[commit-bot: I haz the power, 2015-12-16 19:28:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1519883003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1519883003/140001

[commit-bot: I haz the power, 2015-12-16 20:00:56]

Description was changed from

==========
1) Add basic configuration (network connection, language, keyboard layout,
timezone) setup page. 
2) Add network setup error page.
3) Format the i18n style in host-pairing-screen.html and
controller-pairing-screen.html.

BUG=564370
==========

to

==========
1) Add basic configuration (network connection, language, keyboard layout,
timezone) setup page. 
2) Add network setup error page.
3) Format the i18n style in host-pairing-screen.html and
controller-pairing-screen.html.

BUG=564370
==========

[commit-bot: I haz the power, 2015-12-16 20:00:58]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2015-12-16 20:02:18]

Description was changed from

==========
1) Add basic configuration (network connection, language, keyboard layout,
timezone) setup page. 
2) Add network setup error page.
3) Format the i18n style in host-pairing-screen.html and
controller-pairing-screen.html.

BUG=564370
==========

to

==========
1) Add basic configuration (network connection, language, keyboard layout,
timezone) setup page.
2) Add network setup error page.
3) Format the i18n style in host-pairing-screen.html and
controller-pairing-screen.html.

BUG=564370

Committed: https://crrev.com/1bc23b7f85b9d927c23a85458ce0e10e644a4b61
Cr-Commit-Position: refs/heads/master@{#365597}
==========

[commit-bot: I haz the power, 2015-12-16 20:02:19]

Patchset 4 (id:??) landed as
https://crrev.com/1bc23b7f85b9d927c23a85458ce0e10e644a4b61
Cr-Commit-Position: refs/heads/master@{#365597}