third_party/WebKit/Source/platform/DEPS - Issue 1519863002: Expose WorkerPool to blink

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/DEPS

Issue 1519863002: Expose WorkerPool to blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use closures + make safe Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/platform/BackgroundTaskRunner.cpp ('K') | « third_party/WebKit/Source/platform/BackgroundTaskRunnerTest.cpp ('k') | third_party/WebKit/Source/platform/blink_platform.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+base/memory",	2 "+base",
	kinuko 2015/12/18 15:21:30 This worries me a bit-- the onion soup doc says ba This worries me a bit-- the onion soup doc says base deps can be added through whitelist, but this allows everything at once. Could we still allow things a bit more slowly like this? (What other reviewers think?) "+base/bind.h" "+base/location.h" If this list gets too bigger we can start considering adding "+base". Actually I even want to disallow bind.h to be included other than in BackgroundTaskRunner.cpp for now, would it make sense to create a subdirectory like platform/threading and have the new files for WorkerPool in it, add its own DEPS to allow bind.h? haraken 2015/12/18 15:30:44 I'd prefer whitelisting header files. Elliott? Show quoted text On 2015/12/18 15:21:30, kinuko wrote: > This worries me a bit-- the onion soup doc says base deps can be added through > whitelist, but this allows everything at once. Could we still allow things a bit > more slowly like this? (What other reviewers think?) > > "+base/bind.h" > "+base/location.h" > > If this list gets too bigger we can start considering adding "+base". > > Actually I even want to disallow bind.h to be included other than in > BackgroundTaskRunner.cpp for now, would it make sense to create a subdirectory > like platform/threading and have the new files for WorkerPool in it, add its own > DEPS to allow bind.h? I'd prefer whitelisting header files. Elliott? Justin Novosad 2015/12/18 15:53:44 Acknowledged. Show quoted text On 2015/12/18 15:30:44, haraken wrote: > On 2015/12/18 15:21:30, kinuko wrote: > > This worries me a bit-- the onion soup doc says base deps can be added through > > whitelist, but this allows everything at once. Could we still allow things a > bit > > more slowly like this? (What other reviewers think?) > > > > "+base/bind.h" > > "+base/location.h" > > > > If this list gets too bigger we can start considering adding "+base". > > > > Actually I even want to disallow bind.h to be included other than in > > BackgroundTaskRunner.cpp for now, would it make sense to create a subdirectory > > like platform/threading and have the new files for WorkerPool in it, add its > own > > DEPS to allow bind.h? > > I'd prefer whitelisting header files. > > Elliott? Acknowledged.
3 "+base/trace_event",

4 "+mozilla",	3 "+mozilla",

5 "+platform",	4 "+platform",

6 "+public/platform",	5 "+public/platform",

7 "+skia/ext",	6 "+skia/ext",

8 "+third_party/khronos",	7 "+third_party/khronos",

9 "+third_party/skia",	8 "+third_party/skia",

10 "+ui/gfx/geometry",	9 "+ui/gfx/geometry",

11 "+url",	10 "+url",

12 "+webp",	11 "+webp",

13 "-bindings",	12 "-bindings",

14 "-core",	13 "-core",

15 "-modules",	14 "-modules",

16 ]	15 ]

OLD	NEW