Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1519833002: Ship Case-insensitive attribute selectors (Closed)

Created:
5 years ago by fs
Modified:
5 years ago
Reviewers:
chrishtr, philipj_slow
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ship Case-insensitive attribute selectors Intent-to-ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/vAWK0ldpyrc BUG=567732 Committed: https://crrev.com/6467e7a0a943e70c2f91f80020bcb47b5c1c9c3a Cr-Commit-Position: refs/heads/master@{#364831}

Patch Set 1 #

Patch Set 2 : Drop feature. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp View 1 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
fs
5 years ago (2015-12-11 18:06:42 UTC) #2
chrishtr
lgtm
5 years ago (2015-12-11 18:09:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1519833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1519833002/1
5 years ago (2015-12-11 18:09:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/142119)
5 years ago (2015-12-11 19:07:45 UTC) #7
philipj_slow
I think you could remove the REF entirely, it's only used in one place and ...
5 years ago (2015-12-11 19:42:02 UTC) #8
fs
On 2015/12/11 at 19:42:02, philipj wrote: > I think you could remove the REF entirely, ...
5 years ago (2015-12-11 21:04:24 UTC) #9
philipj_slow
lgtm
5 years ago (2015-12-11 22:46:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1519833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1519833002/20001
5 years ago (2015-12-11 22:47:21 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-11 23:26:03 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-11 23:27:09 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6467e7a0a943e70c2f91f80020bcb47b5c1c9c3a
Cr-Commit-Position: refs/heads/master@{#364831}

Powered by Google App Engine
This is Rietveld 408576698