Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1519823002: [wasm] Fixed FxxMin and FxxMax for cases where one operand is NaN. (Closed)

Created:
5 years ago by ahaas
Modified:
5 years ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fixed FxxMin and FxxMax for cases where one operand is NaN. R=titzer@chromium.org Committed: https://crrev.com/746cd5f8567913a260dda67679be7360700c4555 Cr-Commit-Position: refs/heads/master@{#32811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -40 lines) Patch
M src/compiler/wasm-compiler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 2 chunks +76 lines, -36 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 4 chunks +48 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ahaas
5 years ago (2015-12-11 14:53:48 UTC) #1
titzer
On 2015/12/11 14:53:48, ahaas wrote: lgtm
5 years ago (2015-12-11 16:06:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1519823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1519823002/1
5 years ago (2015-12-11 16:07:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 16:40:01 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-11 16:40:16 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/746cd5f8567913a260dda67679be7360700c4555
Cr-Commit-Position: refs/heads/master@{#32811}

Powered by Google App Engine
This is Rietveld 408576698