Remove data belonging to a public account when the account is removed

Remove data belonging to a public account when the account is removed

When a public account is removed, data stored for this account outside its
ephemeral cryptohome should be removed as well. The original implementation
of this clean-up step was wrong, leaving stale data behind when an account
is removed and the user is not currently logged into it. This CL ensures
that the data belonging to all removed public accounts is cleaned up.

BUG=241083
TEST=Manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200573

[bartfab (slow), 2013-05-15 18:16:15]

Hi Nikita,

Could you take a look?

[Nikita (slow), 2013-05-16 08:28:24]

lgtm

Is there a test for this code? Should it be added/updated?

[bartfab (slow), 2013-05-16 08:54:01]

You are right, we should add tests for this code. I filed issue 241357 for that.
If you look at that issue, you will see that it lists three cases which should
be tested.

1/ was working correctly all along.
2/ is fixed by this CL.
3/ was actually slightly broken as well and is fixed by this CL.

[commit-bot: I haz the power, 2013-05-16 08:54:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/15198005/1

[commit-bot: I haz the power, 2013-05-16 09:40:06]

Retried try job too often on linux_chromeos for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-16 09:42:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/15198005/1

[commit-bot: I haz the power, 2013-05-16 10:21:25]

Retried try job too often on linux_chromeos for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-16 10:35:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/15198005/1

[commit-bot: I haz the power, 2013-05-16 11:10:43]

Retried try job too often on linux_chromeos for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-16 11:21:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/15198005/1

[commit-bot: I haz the power, 2013-05-16 12:04:40]

Retried try job too often on linux_chromeos for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-16 12:05:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/15198005/1

[commit-bot: I haz the power, 2013-05-16 12:43:18]

Retried try job too often on linux_chromeos for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-16 14:36:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/15198005/1

[commit-bot: I haz the power, 2013-05-16 15:25:46]

Retried try job too often on linux_chromeos for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-16 15:55:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/15198005/1

[commit-bot: I haz the power, 2013-05-16 16:30:17]

Retried try job too often on linux_chromeos for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-16 16:32:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/15198005/1

[commit-bot: I haz the power, 2013-05-16 17:07:04]

Retried try job too often on linux_chromeos for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-16 17:19:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/15198005/1

[commit-bot: I haz the power, 2013-05-16 17:56:31]

Change committed as 200573