Don't constant fold large strings.

Don't constant fold large strings.

This fixes a 10k regression in swarm.  Marked with appropriate TODOs.

R=asgerf@google.com

Committed: https://github.com/dart-lang/sdk/commit/04e3f8520c5d7534e3213bdef4f4cd684a1369d1

[sra1, 2015-12-11 05:52:14]

sra@google.com changed reviewers:
+ asgerf@google.com

[asgerf, 2015-12-11 12:27:12]

lgtm if the check is moved to visitLetPrim

https://codereview.chromium.org/1519773002/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right):

https://codereview.chromium.org/1519773002/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/type_propagation.dart:849: if (value.isConstant) {
I think we should just do the check here.

https://codereview.chromium.org/1519773002/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/type_propagation.dart:2554: const int
MAXIMUM_LENGTH_OF_DUPLICATED_STRING = 500;
I think the better place to do this is in visitLetPrim above (I put a comment
there).  The operation itself should still be eliminated if it has no uses.

[sra1, 2015-12-11 19:13:26]

https://chromiumcodereview.appspot.com/1519773002/diff/1/pkg/compiler/lib/src...
File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right):

https://chromiumcodereview.appspot.com/1519773002/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/cps_ir/type_propagation.dart:849: if (value.isConstant) {
On 2015/12/11 12:27:12, asgerf wrote:
> I think we should just do the check here.

Done.

https://chromiumcodereview.appspot.com/1519773002/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/cps_ir/type_propagation.dart:2554: const int
MAXIMUM_LENGTH_OF_DUPLICATED_STRING = 500;
On 2015/12/11 12:27:12, asgerf wrote:
> I think the better place to do this is in visitLetPrim above (I put a comment
> there).  The operation itself should still be eliminated if it has no uses.

Done.

[sra1, 2015-12-11 19:33:09]

Description was changed from

==========
Don't constant fold large strings.

This fixes a 10k regression in swarm.  Marked with appropriate TODOs.
==========

to

==========
Don't constant fold large strings.

This fixes a 10k regression in swarm.  Marked with appropriate TODOs.

R=asgerf@google.com

Committed:
https://github.com/dart-lang/sdk/commit/04e3f8520c5d7534e3213bdef4f4cd684a1369d1
==========

[sra1, 2015-12-11 19:33:09]

Committed patchset #1 (id:1) manually as
04e3f8520c5d7534e3213bdef4f4cd684a1369d1 (presubmit successful).