Serialize font shorthand as empty string if any longhand is not specified

Serialize font shorthand as empty string if any longhand is not specified
(if the font shorthand is set all the longhands will be set).

Currently we only require font-size and font-family to be set for the font shorthand to be serialized as non-empty (font-size, font-family, and all the remaining longhands that are not 'normal').

Firefox serializes font as empty string unless all font longhands are set in the stylesheet (including non standard font longhands), but this behavior is inconsistent.

BUG=398239
Committed: https://crrev.com/44c56e14d83953ef593d0692fc22a150249f4630
Cr-Commit-Position: refs/heads/master@{#365166}

[Bugs Nash, 2015-12-10 21:39:20]

Description was changed from

==========
Made the serialized font shorthand value return empty unless ALL of the
font longhands are set.

BUG=398239
==========

to

==========
Made the serialized font shorthand value return empty unless ALL of the
font longhands are set (if the font shorthand is set all the longhands will be
set).

Firefox returns empty unless the font shorthand itself is set in the stylesheet.

BUG=398239
==========

[Bugs Nash, 2015-12-10 21:39:20]

bugsnash@chromium.org changed reviewers:
+ alancutter@chromium.org, timloh@chromium.org

[Timothy Loh, 2015-12-11 01:12:44]

On 2015/12/10 21:41:16, Bugs Nash wrote:

ok lgtm, but:
- First line of patch description shouldn't be wrapped because this is used as
the patch title. Also maybe something like "Serialize font shorthand as empty
string if any longhand is not specified" reads better
- It's useful to mention the current behaviour in the patch description (i.e. we
only currently require font-size and font-family)
- I'm doubtful that FF behaves as you suggest. Probably they have some other
longhand values also?

[Bugs Nash, 2015-12-11 02:50:27]

Description was changed from

==========
Made the serialized font shorthand value return empty unless ALL of the
font longhands are set (if the font shorthand is set all the longhands will be
set).

Firefox returns empty unless the font shorthand itself is set in the stylesheet.

BUG=398239
==========

to

==========
Serialize font shorthand as empty string if any longhand is not specified
(if the font shorthand is set all the longhands will be set).

Firefox returns empty unless the font shorthand itself is set in the stylesheet.

BUG=398239
==========

[Bugs Nash, 2015-12-11 02:53:32]

Description was changed from

==========
Serialize font shorthand as empty string if any longhand is not specified
(if the font shorthand is set all the longhands will be set).

Firefox returns empty unless the font shorthand itself is set in the stylesheet.

BUG=398239
==========

to

==========
Serialize font shorthand as empty string if any longhand is not specified
(if the font shorthand is set all the longhands will be set).

Currently we only require font-size and font-family to be set for the font
shorthand to be serialized as non-empty (font-size, font-family, and all the
remaining longhands that are not 'normal').

Firefox serializes font as empty string unless the font shorthand itself is set
in the stylesheet.

BUG=398239
==========

[Bugs Nash, 2015-12-11 02:55:21]

On 2015/12/11 at 01:12:44, timloh wrote:
> On 2015/12/10 21:41:16, Bugs Nash wrote:
> 
> ok lgtm, but:
> - First line of patch description shouldn't be wrapped because this is used as
the patch title. Also maybe something like "Serialize font shorthand as empty
string if any longhand is not specified" reads better
> - It's useful to mention the current behaviour in the patch description (i.e.
we only currently require font-size and font-family)
> - I'm doubtful that FF behaves as you suggest. Probably they have some other
longhand values also?


Description changed. What other longhands could FF have? This seems to suggest I
have covered them all: https://developer.mozilla.org/en/docs/Web/CSS/font

[Timothy Loh, 2015-12-14 02:15:05]

On 2015/12/11 02:55:21, Bugs Nash wrote:
> On 2015/12/11 at 01:12:44, timloh wrote:
> > On 2015/12/10 21:41:16, Bugs Nash wrote:
> > 
> > ok lgtm, but:
> > - First line of patch description shouldn't be wrapped because this is used
as
> the patch title. Also maybe something like "Serialize font shorthand as empty
> string if any longhand is not specified" reads better
> > - It's useful to mention the current behaviour in the patch description
(i.e.
> we only currently require font-size and font-family)
> > - I'm doubtful that FF behaves as you suggest. Probably they have some other
> longhand values also?
> 
> 
> Description changed. What other longhands could FF have? This seems to suggest
I
> have covered them all: https://developer.mozilla.org/en/docs/Web/CSS/font

Check in FFs devtools, they sometimes have -moz- prefixed longhands.

[Bugs Nash, 2015-12-14 03:53:00]

Description was changed from

==========
Serialize font shorthand as empty string if any longhand is not specified
(if the font shorthand is set all the longhands will be set).

Currently we only require font-size and font-family to be set for the font
shorthand to be serialized as non-empty (font-size, font-family, and all the
remaining longhands that are not 'normal').

Firefox serializes font as empty string unless the font shorthand itself is set
in the stylesheet.

BUG=398239
==========

to

==========
Serialize font shorthand as empty string if any longhand is not specified
(if the font shorthand is set all the longhands will be set).

Currently we only require font-size and font-family to be set for the font
shorthand to be serialized as non-empty (font-size, font-family, and all the
remaining longhands that are not 'normal').

Firefox serializes font as empty string unless all font longhands are set in the
stylesheet (including non standard font longhands), but this behavior is
inconsistent.

BUG=398239
==========

[Bugs Nash, 2015-12-14 03:54:51]

On 2015/12/14 at 02:15:05, timloh wrote:
> On 2015/12/11 02:55:21, Bugs Nash wrote:
> > On 2015/12/11 at 01:12:44, timloh wrote:
> > > On 2015/12/10 21:41:16, Bugs Nash wrote:
> > > 
> > > ok lgtm, but:
> > > - First line of patch description shouldn't be wrapped because this is
used as
> > the patch title. Also maybe something like "Serialize font shorthand as
empty
> > string if any longhand is not specified" reads better
> > > - It's useful to mention the current behaviour in the patch description
(i.e.
> > we only currently require font-size and font-family)
> > > - I'm doubtful that FF behaves as you suggest. Probably they have some
other
> > longhand values also?
> > 
> > 
> > Description changed. What other longhands could FF have? This seems to
suggest I
> > have covered them all: https://developer.mozilla.org/en/docs/Web/CSS/font
> 
> Check in FFs devtools, they sometimes have -moz- prefixed longhands.


You are correct, but the behavior is inconsistent. Updated description.

[Bugs Nash, 2015-12-14 23:07:47]

The CQ bit was checked by bugsnash@chromium.org

[commit-bot: I haz the power, 2015-12-14 23:08:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1519643002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1519643002/1

[commit-bot: I haz the power, 2015-12-15 01:16:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-15 01:16:07]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Bugs Nash, 2015-12-15 03:43:54]

The CQ bit was checked by bugsnash@chromium.org

[commit-bot: I haz the power, 2015-12-15 03:46:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1519643002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1519643002/1

[commit-bot: I haz the power, 2015-12-15 05:37:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-15 05:38:11]

Description was changed from

==========
Serialize font shorthand as empty string if any longhand is not specified
(if the font shorthand is set all the longhands will be set).

Currently we only require font-size and font-family to be set for the font
shorthand to be serialized as non-empty (font-size, font-family, and all the
remaining longhands that are not 'normal').

Firefox serializes font as empty string unless all font longhands are set in the
stylesheet (including non standard font longhands), but this behavior is
inconsistent.

BUG=398239
==========

to

==========
Serialize font shorthand as empty string if any longhand is not specified
(if the font shorthand is set all the longhands will be set).

Currently we only require font-size and font-family to be set for the font
shorthand to be serialized as non-empty (font-size, font-family, and all the
remaining longhands that are not 'normal').

Firefox serializes font as empty string unless all font longhands are set in the
stylesheet (including non standard font longhands), but this behavior is
inconsistent.

BUG=398239

Committed: https://crrev.com/44c56e14d83953ef593d0692fc22a150249f4630
Cr-Commit-Position: refs/heads/master@{#365166}
==========

[commit-bot: I haz the power, 2015-12-15 05:38:11]

Patchset 1 (id:??) landed as
https://crrev.com/44c56e14d83953ef593d0692fc22a150249f4630
Cr-Commit-Position: refs/heads/master@{#365166}