Remove duplicated code from sync related unit tests.

chrome/browser/notifications/extension_welcome_notification_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/extension_welcome_notification.h"
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/test_simple_task_runner.h"
 #include "base/thread_task_runner_handle.h"
 #include "chrome/browser/notifications/notification.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/testing_pref_service_syncable.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/user_prefs/pref_registry_syncable.h"
+#include "sync/api/fake_sync_change_processor.h"
 #include "sync/api/sync_error_factory_mock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/message_center/fake_message_center.h"
 #include "ui/message_center/notification.h"
 
 const char kChromeNowExtensionID[] = "pafkbggdmjlpgkdkcbjmhmfcdpncadgh";
 
 class MockMessageCenter : public message_center::FakeMessageCenter {
  public:
   MockMessageCenter()
@@ skipping 79 matching lines @@
     task_to_run.Run();
   }
 
 private:
   base::Time start_time_;
   base::TimeDelta elapsed_time_;
   scoped_ptr<MockMessageCenter> message_center_;
   base::Closure pending_task_;
 };
 
-class TestSyncProcessor : public syncer::SyncChangeProcessor {
-  virtual syncer::SyncError ProcessSyncChanges(
-      const tracked_objects::Location& from_here,
-      const syncer::SyncChangeList& change_list) OVERRIDE {
-    return syncer::SyncError();
-  }
-
-  virtual syncer::SyncDataList GetAllSyncData(syncer::ModelType type)
-      const OVERRIDE {
-    return syncer::SyncDataList();
-  }
-};
-
 class ExtensionWelcomeNotificationTest : public testing::Test {
  protected:
   ExtensionWelcomeNotificationTest() {
     scoped_refptr<user_prefs::PrefRegistrySyncable> pref_registry(
         new user_prefs::PrefRegistrySyncable());
     ExtensionWelcomeNotification::RegisterProfilePrefs(pref_registry.get());
   }
 
   virtual void SetUp() {
     task_runner_ = new base::TestSimpleTaskRunner();
     thread_task_runner_handle_.reset(
         new base::ThreadTaskRunnerHandle(task_runner_));
     profile_.reset(new TestingProfile());
     delegate_ = new WelcomeNotificationDelegate();
     welcome_notification_ = ExtensionWelcomeNotification::Create(
         kChromeNowExtensionID, profile_.get(), delegate_);
   }
 
   virtual void TearDown() {
     delegate_ = NULL;
     welcome_notification_.reset();
     profile_.reset();
     thread_task_runner_handle_.reset();
     task_runner_ = NULL;
   }
 
   void StartPreferenceSyncing() {
     PrefServiceSyncable::FromProfile(profile_.get())
         ->GetSyncableService(syncer::PREFERENCES)
-        ->MergeDataAndStartSyncing(
-              syncer::PREFERENCES,
-              syncer::SyncDataList(),
-              scoped_ptr<syncer::SyncChangeProcessor>(new TestSyncProcessor),
-              scoped_ptr<syncer::SyncErrorFactory>(
-                  new syncer::SyncErrorFactoryMock()));
+        ->MergeDataAndStartSyncing(syncer::PREFERENCES,
+                                   syncer::SyncDataList(),
+                                   scoped_ptr<syncer::SyncChangeProcessor>(
+                                       new syncer::FakeSyncChangeProcessor),
+                                   scoped_ptr<syncer::SyncErrorFactory>(
+                                       new syncer::SyncErrorFactoryMock()));
   }
 
   void ShowChromeNowNotification() {
     ShowNotification(
         "ChromeNowNotification",
         message_center::NotifierId(message_center::NotifierId::APPLICATION,
                                    kChromeNowExtensionID));
   }
 
   void ShowRegularNotification() {
@@ skipping 268 matching lines @@
   EXPECT_TRUE(task_runner()->GetPendingTasks().empty());
   EXPECT_TRUE(message_center()->add_notification_calls() == 1);
   EXPECT_TRUE(message_center()->remove_notification_calls() == 1);
   EXPECT_TRUE(message_center()->notifications_with_shown_as_popup() == 0);
   EXPECT_TRUE(GetBooleanPref(prefs::kWelcomeNotificationDismissed));
   EXPECT_TRUE(GetBooleanPref(prefs::kWelcomeNotificationPreviouslyPoppedUp));
   EXPECT_TRUE(
       GetInt64Pref(prefs::kWelcomeNotificationExpirationTimestamp) ==
           (GetStartTime() + requested_show_time).ToInternalValue());
 }