Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Side by Side Diff: components/browser_sync/browser/profile_sync_service.h

Issue 1519593002: [Sync] Fix comment for the SyncInitialState enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_SERVICE_H_ 5 #ifndef COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_SERVICE_H_
6 #define COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_SERVICE_H_ 6 #define COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_SERVICE_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 624 matching lines...) Expand 10 before | Expand all | Expand 10 after
635 }; 635 };
636 636
637 enum AuthErrorMetric { 637 enum AuthErrorMetric {
638 AUTH_ERROR_ENCOUNTERED, 638 AUTH_ERROR_ENCOUNTERED,
639 AUTH_ERROR_FIXED, 639 AUTH_ERROR_FIXED,
640 AUTH_ERROR_LIMIT 640 AUTH_ERROR_LIMIT
641 }; 641 };
642 642
643 // The initial state of sync, for the Sync.InitialState histogram. Even if 643 // The initial state of sync, for the Sync.InitialState histogram. Even if
644 // this value is CAN_START, sync startup might fail for reasons that we may 644 // this value is CAN_START, sync startup might fail for reasons that we may
645 // want to consider logging in the future, such as sync being disabled via 645 // want to consider logging in the future, such as a passphrase needed for
646 // Google Dashboard (birthday error), a passphrase needed for decryption, or 646 // decryption, or the version of Chrome being too old. This enum is used to
647 // the version of Chrome being too old. This enum is used to back a UMA 647 // back a UMA histogram, and should therefore be treated as append-only.
648 // histogram, and should therefore be treated as append-only.
649 enum SyncInitialState { 648 enum SyncInitialState {
650 CAN_START, // Sync can attempt to start up. 649 CAN_START, // Sync can attempt to start up.
651 NOT_SIGNED_IN, // There is no signed in user. 650 NOT_SIGNED_IN, // There is no signed in user.
652 NOT_REQUESTED, // The user turned off sync. 651 NOT_REQUESTED, // The user turned off sync.
653 NOT_REQUESTED_NOT_SETUP, // The user turned off sync and setup completed 652 NOT_REQUESTED_NOT_SETUP, // The user turned off sync and setup completed
654 // is false. Might indicate a stop-and-clear. 653 // is false. Might indicate a stop-and-clear.
655 NEEDS_CONFIRMATION, // The user must confirm sync settings. 654 NEEDS_CONFIRMATION, // The user must confirm sync settings.
656 IS_MANAGED, // Sync is disallowed by enterprise policy. 655 IS_MANAGED, // Sync is disallowed by enterprise policy.
657 SYNC_INITIAL_STATE_LIMIT 656 SYNC_INITIAL_STATE_LIMIT
658 }; 657 };
(...skipping 369 matching lines...) Expand 10 before | Expand all | Expand 10 after
1028 base::WeakPtrFactory<ProfileSyncService> startup_controller_weak_factory_; 1027 base::WeakPtrFactory<ProfileSyncService> startup_controller_weak_factory_;
1029 1028
1030 DISALLOW_COPY_AND_ASSIGN(ProfileSyncService); 1029 DISALLOW_COPY_AND_ASSIGN(ProfileSyncService);
1031 }; 1030 };
1032 1031
1033 bool ShouldShowActionOnUI( 1032 bool ShouldShowActionOnUI(
1034 const syncer::SyncProtocolError& error); 1033 const syncer::SyncProtocolError& error);
1035 1034
1036 1035
1037 #endif // COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_SERVICE_H_ 1036 #endif // COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_SERVICE_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698