Change SkTaskGroup to use std::function.

Change SkTaskGroup to use std::function. Ripple all the changes.

BUG=skia:4634
Committed: https://skia.googlesource.com/skia/+/30da5f7a1e4cf0daa2f284b4cae5128b23f0db96

[herb_g, 2015-12-10 18:10:17]

ws

[herb_g, 2015-12-10 18:11:50]

Description was changed from

==========
Change SkTaskGroup to use std::function.

BUG=skia:
==========

to

==========
Change SkTaskGroup to use std::function. Ripple all the changes.

BUG=skia:
==========

[herb_g, 2015-12-10 18:11:50]

herb@google.com changed reviewers:
+ mtklein@google.com

[herb_g, 2015-12-10 18:12:17]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-10 18:12:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1519573003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1519573003/20001

[commit-bot: I haz the power, 2015-12-10 18:13:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-10 18:13:13]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)

[herb_g, 2015-12-10 18:40:14]

Fix compiler breakage.

[herb_g, 2015-12-10 18:40:42]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-10 18:40:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1519573003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1519573003/40001

[commit-bot: I haz the power, 2015-12-10 18:52:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-10 18:52:42]

Dry run: This issue passed the CQ dry run.

[herb_g, 2015-12-10 18:58:00]

Description was changed from

==========
Change SkTaskGroup to use std::function. Ripple all the changes.

BUG=skia:
==========

to

==========
Change SkTaskGroup to use std::function. Ripple all the changes.

BUG=skia:4634
==========

[mtklein, 2015-12-10 20:58:35]

https://codereview.chromium.org/1519573003/diff/40001/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1519573003/diff/40001/dm/DM.cpp#newcode1117
dm/DM.cpp:1117: tg.batch([t](int j) { Task::Run(&t[j]); },
currentEnclave->count());
Seems like "Task* t" doesn't need to exist?

  SkTArray<Task>* enclave = &enclaves[i];
  ...
  tg.batch([enclave](int j) { Task::Run(&(*enclave)[j]); }, enclave->count()); 

something like that?

https://codereview.chromium.org/1519573003/diff/40001/src/core/SkTaskGroup.cpp
File src/core/SkTaskGroup.cpp (right):

https://codereview.chromium.org/1519573003/diff/40001/src/core/SkTaskGroup.cp...
src/core/SkTaskGroup.cpp:125: this->add(nullptr, &dummy);
So does nullptr turn into a std::function<void(void)> where operator bool
returns false?  If so, neat.

https://codereview.chromium.org/1519573003/diff/40001/src/core/SkTaskGroup.h
File src/core/SkTaskGroup.h (right):

https://codereview.chromium.org/1519573003/diff/40001/src/core/SkTaskGroup.h#...
src/core/SkTaskGroup.h:37: // Equivalent to a loop over add(fn, arg), but with
perhaps less synchronization overhead.
Might just remove this second line now?

[herb_g, 2015-12-10 21:58:07]

address comments

[herb_g, 2015-12-10 21:58:36]

PTAL

https://codereview.chromium.org/1519573003/diff/40001/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1519573003/diff/40001/dm/DM.cpp#newcode1117
dm/DM.cpp:1117: tg.batch([t](int j) { Task::Run(&t[j]); },
currentEnclave->count());
On 2015/12/10 at 20:58:35, mtklein wrote:
> Seems like "Task* t" doesn't need to exist?
> 
>   SkTArray<Task>* enclave = &enclaves[i];
>   ...
>   tg.batch([enclave](int j) { Task::Run(&(*enclave)[j]); }, enclave->count());

> 
> something like that?
Done

https://codereview.chromium.org/1519573003/diff/40001/src/core/SkTaskGroup.cpp
File src/core/SkTaskGroup.cpp (right):

https://codereview.chromium.org/1519573003/diff/40001/src/core/SkTaskGroup.cp...
src/core/SkTaskGroup.cpp:125: this->add(nullptr, &dummy);
On 2015/12/10 at 20:58:35, mtklein wrote:
> So does nullptr turn into a std::function<void(void)> where operator bool
returns false?  If so, neat.

Yes. Yes it does. I got lucky.

https://codereview.chromium.org/1519573003/diff/40001/src/core/SkTaskGroup.h
File src/core/SkTaskGroup.h (right):

https://codereview.chromium.org/1519573003/diff/40001/src/core/SkTaskGroup.h#...
src/core/SkTaskGroup.h:37: // Equivalent to a loop over add(fn, arg), but with
perhaps less synchronization overhead.
On 2015/12/10 at 20:58:35, mtklein wrote:
> Might just remove this second line now?

Done

[herb_g, 2015-12-10 21:59:46]

The CQ bit was checked by herb@google.com

[commit-bot: I haz the power, 2015-12-10 21:59:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1519573003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1519573003/60001

[commit-bot: I haz the power, 2015-12-10 21:59:56]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-12-11 03:59 UTC

[mtklein, 2015-12-10 22:01:15]

lgtm

[commit-bot: I haz the power, 2015-12-10 22:12:36]

Description was changed from

==========
Change SkTaskGroup to use std::function. Ripple all the changes.

BUG=skia:4634
==========

to

==========
Change SkTaskGroup to use std::function. Ripple all the changes.

BUG=skia:4634

Committed:
https://skia.googlesource.com/skia/+/30da5f7a1e4cf0daa2f284b4cae5128b23f0db96
==========

[commit-bot: I haz the power, 2015-12-10 22:12:38]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/30da5f7a1e4cf0daa2f284b4cae5128b23f0db96