Use a monotonic clock in the implementation of Timer.

Use a monotonic clock in the implementation of Timer.

Ask the embedder for the current time, since it is the embedder who later compares the deadline with current time when deciding when to send a wake up message.

BUG=http://dartbug.com/25055
BUG=http://dartbug.com/25216
R=iposva@google.com, zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/9387fead15f6158abc502702d0091c355d69dec3

[rmacnak, 2015-12-10 21:38:42]

Description was changed from

==========
Use a monotonic clock in the implementation of Timer.

BUG=http://dartbug.com/25055
==========

to

==========
Use a monotonic clock in the implementation of Timer.

Ask the embedder for the current time, since it is the embedder who later
compares the deadline with current time when deciding when to send a wake up
message.

BUG=http://dartbug.com/25055
BUG=http://dartbug.com/25216
==========

[rmacnak, 2015-12-10 22:14:53]

rmacnak@google.com changed reviewers:
+ iposva@google.com, zra@google.com

[zra, 2015-12-10 22:53:46]

https://chromiumcodereview.appspot.com/1519563003/diff/80001/runtime/bin/util...
File runtime/bin/utils_android.cc (right):

https://chromiumcodereview.appspot.com/1519563003/diff/80001/runtime/bin/util...
runtime/bin/utils_android.cc:84: // Convert to microseconds.
Maybe try to pull out the conversion code for at least Android and Linux into
utility functions in the header.

https://chromiumcodereview.appspot.com/1519563003/diff/80001/runtime/lib/inte...
File runtime/lib/internal_patch.dart (right):

https://chromiumcodereview.appspot.com/1519563003/diff/80001/runtime/lib/inte...
runtime/lib/internal_patch.dart:14: // Example: "dart:io
_EventHandler._timerMillisecondClock"
Other than the call site, this is the only place it is documented how this field
should be populated by the embedder. Maybe a little more guidance here would be
appropriate. Maybe just a function type like () -> int would be enough.

[rmacnak, 2015-12-11 18:39:40]

https://chromiumcodereview.appspot.com/1519563003/diff/80001/runtime/bin/util...
File runtime/bin/utils_android.cc (right):

https://chromiumcodereview.appspot.com/1519563003/diff/80001/runtime/bin/util...
runtime/bin/utils_android.cc:84: // Convert to microseconds.
On 2015/12/10 22:53:46, zra wrote:
> Maybe try to pull out the conversion code for at least Android and Linux into
> utility functions in the header.

I think this code should remain unseparated and the same as its counterpart in
OS::GetCurrentMonotonicMicros

https://chromiumcodereview.appspot.com/1519563003/diff/80001/runtime/lib/inte...
File runtime/lib/internal_patch.dart (right):

https://chromiumcodereview.appspot.com/1519563003/diff/80001/runtime/lib/inte...
runtime/lib/internal_patch.dart:14: // Example: "dart:io
_EventHandler._timerMillisecondClock"
On 2015/12/10 22:53:46, zra wrote:
> Other than the call site, this is the only place it is documented how this
field
> should be populated by the embedder. Maybe a little more guidance here would
be
> appropriate. Maybe just a function type like () -> int would be enough.

Added.

Noting that eventHandlerSendData has a far more complicated undocumented API.

[Ivan Posva, 2015-12-11 20:21:02]

LGTM

Thanks,
-Ivan

[zra, 2015-12-11 20:22:34]

lgtm

[rmacnak, 2015-12-11 20:39:59]

Description was changed from

==========
Use a monotonic clock in the implementation of Timer.

Ask the embedder for the current time, since it is the embedder who later
compares the deadline with current time when deciding when to send a wake up
message.

BUG=http://dartbug.com/25055
BUG=http://dartbug.com/25216
==========

to

==========
Use a monotonic clock in the implementation of Timer.

Ask the embedder for the current time, since it is the embedder who later
compares the deadline with current time when deciding when to send a wake up
message.

BUG=http://dartbug.com/25055
BUG=http://dartbug.com/25216
R=iposva@google.com, zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9387fead15f6158abc502702d0091c355d69dec3
==========

[rmacnak, 2015-12-11 20:40:00]

Committed patchset #6 (id:100001) manually as
9387fead15f6158abc502702d0091c355d69dec3 (presubmit successful).