chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java - Issue 1519523002: [Android] Support conditional test disabling based on android.os.Build values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java

Issue 1519523002: [Android] Support conditional test disabling based on android.os.Build values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix one outdated use of SkipCheck Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/test/android/junit/src/org/chromium/base/test/util/DisableIfTest.java ('k') | chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java

index be7e7faff9d6007c590a28dbe4e78bd464e470ee..bb2073c5a5f3db6c28a7d98f87b564846139d7b6 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java

@@ -13,7 +13,7 @@ import android.text.TextUtils;

import android.view.KeyEvent;

import org.chromium.base.ThreadUtils;

-import org.chromium.base.test.util.DisabledTest;

+import org.chromium.base.test.util.DisableIf;

import org.chromium.base.test.util.Feature;

import org.chromium.base.test.util.Restriction;

import org.chromium.base.test.util.UrlUtils;

@@ -355,7 +355,9 @@ public class NavigateTest extends ChromeTabbedActivityTestBase {

}

- @DisabledTest // Fails on android-one: crbug.com/540723

+ @DisableIf.Build(

+ hardware_is = "sprout",

+ message = "fails on android-one: crbug.com/540723")

@MediumTest

@Feature({"Navigation"})

public void testWindowOpenUrlSpoof() throws Exception {