Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3559)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java

Issue 1519523002: [Android] Support conditional test disabling based on android.os.Build values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java
index be7e7faff9d6007c590a28dbe4e78bd464e470ee..ba1bad888d71f086156911d700cc7f49cc96ba6c 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java
@@ -13,7 +13,7 @@ import android.text.TextUtils;
import android.view.KeyEvent;
import org.chromium.base.ThreadUtils;
-import org.chromium.base.test.util.DisabledTest;
+import org.chromium.base.test.util.DisableIf;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.Restriction;
import org.chromium.base.test.util.UrlUtils;
@@ -355,7 +355,7 @@ public class NavigateTest extends ChromeTabbedActivityTestBase {
}
}
- @DisabledTest // Fails on android-one: crbug.com/540723
+ @DisableIf.Build(hardware_is = "sprout") // Fails on android-one: crbug.com/540723
jbudorick 2015/12/10 15:23:15 There are, unsurprisingly, other tests where this
Yaron 2015/12/11 02:22:16 :( Should we include a message= attribute which ca
jbudorick 2015/12/17 02:08:13 I like this idea, but I'll address how the test ru
Yaron 2015/12/17 15:12:37 Right. So what options do we provide for sheriffs
jbudorick 2015/12/18 17:43:06 Hm, ok.
@MediumTest
@Feature({"Navigation"})
public void testWindowOpenUrlSpoof() throws Exception {

Powered by Google App Engine
This is Rietveld 408576698