Move public API for elements into a public location

Move public API for elements into a public location

In addition to moving code from inside 'src' to outside 'src', I made four other changes:
- cleaned up several comments that had just gotten out of date,
- made FunctionTypedElement implement TypeDefiningElement, and
- moved the implementation of InterfaceType.getSmartLeastUpperBound to InterfaceTypeImpl
- Element kinds EMBEDDED_HTML_SCRIPT, EXTERNAL_HTML_SCRIPT, and HTML have been
removed.

R=paulberry@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/86472f32ce152a1dec6b71fe43c875621f801d10

[Brian Wilkerson, 2015-12-12 19:14:29]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com, scheglov@google.com

[Brian Wilkerson, 2015-12-12 19:14:30]

In addition to moving code from inside 'src' to outside 'src', I made three
other kinds of changes:
- cleaned up several comments that had just gotten out of date,
- made FunctionTypedElement implement TypeDefiningElement, and
- moved the implementation of InterfaceType.getSmartLeastUpperBound to
InterfaceTypeImpl.

[scheglov, 2015-12-12 20:31:29]

LGTM

[Paul Berry, 2015-12-13 16:33:42]

lgtm, however I'm not thrilled about the fact that in addition to a large amount
of code motion, this CL makes a number of minor semantic changes.  Before
committing, could you please edit the issue description to call out the
following changes, so that they will appear in the commit message?

- Element kinds EMBEDDED_HTML_SCRIPT, EXTERNAL_HTML_SCRIPT, and HTML have been
removed.

[Paul Berry, 2015-12-13 16:35:13]

On 2015/12/13 16:33:42, Paul Berry wrote:
> lgtm, however I'm not thrilled about the fact that in addition to a large
amount
> of code motion, this CL makes a number of minor semantic changes.  Before
> committing, could you please edit the issue description to call out the
> following changes, so that they will appear in the commit message?
> 
> - Element kinds EMBEDDED_HTML_SCRIPT, EXTERNAL_HTML_SCRIPT, and HTML have been
> removed.

Sorry, I hit "send" too soon.  I thought there were other changes I was
concerned about, but this is the only one.  Thanks!

[Brian Wilkerson, 2015-12-13 18:48:59]

Description was changed from

==========
Move public API for elements into a public location
==========

to

==========
Move public API for elements into a public location

R=paulberry@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/86472f32ce152a1dec6b71fe43c875621f801d10
==========

[Brian Wilkerson, 2015-12-13 18:49:01]

Committed patchset #1 (id:1) manually as
86472f32ce152a1dec6b71fe43c875621f801d10 (presubmit successful).

[Brian Wilkerson, 2015-12-13 18:50:44]

Description was changed from

==========
Move public API for elements into a public location

R=paulberry@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/86472f32ce152a1dec6b71fe43c875621f801d10
==========

to

==========
Move public API for elements into a public location

In addition to moving code from inside 'src' to outside 'src', I made four other
changes:
- cleaned up several comments that had just gotten out of date,
- made FunctionTypedElement implement TypeDefiningElement, and
- moved the implementation of InterfaceType.getSmartLeastUpperBound to
InterfaceTypeImpl
- Element kinds EMBEDDED_HTML_SCRIPT, EXTERNAL_HTML_SCRIPT, and HTML have been
removed.

R=paulberry@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/86472f32ce152a1dec6b71fe43c875621f801d10
==========