content/browser/download/save_file_manager.h - Issue 1519283002: Fix a use-after-free of SaveFileCreateInfo in SaveFileManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/save_file_manager.h

Issue 1519283002: Fix a use-after-free of SaveFileCreateInfo in SaveFileManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changing parameter declaration to const-ref. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/download/save_file_manager.h

diff --git a/content/browser/download/save_file_manager.h b/content/browser/download/save_file_manager.h

index 9b0abe502956a37687aadc2bbc5f2835dfa58d2f..906acf4d5fbcc69bfd33e7e3847f0f3d38dce41f 100644

--- a/content/browser/download/save_file_manager.h

+++ b/content/browser/download/save_file_manager.h

@@ -161,7 +161,7 @@ class SaveFileManager : public base::RefCountedThreadSafe<SaveFileManager> {

// Lookup the SaveManager for this WebContents' saving browser context and

// inform it the saving job has been started.

- void OnStartSave(const SaveFileCreateInfo* info);

+ void OnStartSave(const SaveFileCreateInfo& info);

// Update the SavePackage with the current state of a started saving job.

// If the SavePackage for this saving job is gone, cancel the request.

void OnUpdateSaveProgress(int save_item_id,

« no previous file with comments | « no previous file | content/browser/download/save_file_manager.cc » ('j') | no next file with comments »