Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1519213004: Roll Dart forward. (Closed)

Created:
5 years ago by zra
Modified:
5 years ago
Reviewers:
Cutch
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Roll Dart forward. - Embedder provides the timer function. - Performance boost (10 - 20%) in IPC RTT benchmark from using new isolate messaging natives in the handle watcher. R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/edb4da03493e4f98509ba3568bd35a0fe381783e

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -14 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/embedder/builtin.dart View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/dart/packages/mojo/sdk_ext/src/natives.dart View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/platform/dart/dart_handle_watcher.cc View 1 2 chunks +5 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zra
Welcome back!
5 years ago (2015-12-14 18:36:37 UTC) #2
Cutch
LGTM but I'm confused by a comment https://codereview.chromium.org/1519213004/diff/1/mojo/public/platform/dart/dart_handle_watcher.cc File mojo/public/platform/dart/dart_handle_watcher.cc (right): https://codereview.chromium.org/1519213004/diff/1/mojo/public/platform/dart/dart_handle_watcher.cc#newcode306 mojo/public/platform/dart/dart_handle_watcher.cc:306: // Dart's ...
5 years ago (2015-12-14 19:07:15 UTC) #3
zra
https://codereview.chromium.org/1519213004/diff/1/mojo/public/platform/dart/dart_handle_watcher.cc File mojo/public/platform/dart/dart_handle_watcher.cc (right): https://codereview.chromium.org/1519213004/diff/1/mojo/public/platform/dart/dart_handle_watcher.cc#newcode306 mojo/public/platform/dart/dart_handle_watcher.cc:306: // Dart's DateTime class uses MojoCoreNatives.timerMillisecondClock(), which On 2015/12/14 ...
5 years ago (2015-12-14 19:22:00 UTC) #4
Cutch
lgtm
5 years ago (2015-12-14 19:26:42 UTC) #5
zra
5 years ago (2015-12-14 19:33:33 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
edb4da03493e4f98509ba3568bd35a0fe381783e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698