Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 151913003: Remove Android filter files for base_unittests (Closed)

Created:
6 years, 10 months ago by Paweł Hajdan Jr.
Modified:
6 years, 10 months ago
Reviewers:
bulach
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Remove Android filter files for base_unittests BUG=339980 R=bulach@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250169

Patch Set 1 #

Patch Set 2 : reupload #

Patch Set 3 : retry #

Patch Set 4 : retry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -35 lines) Patch
D build/android/pylib/gtest/filter/base_unittests_disabled View 1 chunk +0 lines, -25 lines 0 comments Download
D build/android/pylib/gtest/filter/base_unittests_emulator_additional_disabled View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paweł Hajdan Jr.
6 years, 10 months ago (2014-02-08 00:26:38 UTC) #1
bulach
lgtm, love red patches with green bots! :)
6 years, 10 months ago (2014-02-08 00:38:54 UTC) #2
Paweł Hajdan Jr.
Committed patchset #4 manually as r250169 (presubmit successful).
6 years, 10 months ago (2014-02-10 19:26:05 UTC) #3
gone
6 years, 10 months ago (2014-02-11 01:53:40 UTC) #4
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/157593007/ by dfalcantara@chromium.org.

The reason for reverting is: Broke the Blink Android Tests (dbg) bot:

http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20(dbg)

Neither of us can repro failures locally, reverting..

Powered by Google App Engine
This is Rietveld 408576698