Implement Style Containment

Implement Style Containment

The only CSS feature we support that is bound by style containment is
counters. This patch adds the concept of an enclosing style containment
ancestor to the tree walking logic in LayoutCounter and avoids crossing
these boundaries when matching counters.

Layout Containment description from spec:
https://drafts.csswg.org/css-containment/#containment-style

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/9W80Kw-z3ss
BUG=561713
Committed: https://crrev.com/f1ded8f72e6c34c6561ba5d95ec7cff42dd82fd1
Cr-Commit-Position: refs/heads/master@{#375684}

[leviw_travelin_and_unemployed, 2015-12-16 22:18:44]

Description was changed from

==========
Implement Style Containment

The only CSS feature we support that is bound by style containment is
counters. This patch adds the concept of an enclosing style containment
ancestor to the tree walking logic in LayoutCounter and avoids crossing
these boundaries when matching counters.

BUG=561713
==========

to

==========
Implement Style Containment

The only CSS feature we support that is bound by style containment is
counters. This patch adds the concept of an enclosing style containment
ancestor to the tree walking logic in LayoutCounter and avoids crossing
these boundaries when matching counters.

Layout Containment description from spec:
https://drafts.csswg.org/css-containment/#containment-style

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/9W80Kw-z3ss
BUG=561713
==========

[leviw_travelin_and_unemployed, 2015-12-16 22:20:24]

leviw@chromium.org changed reviewers:
+ esprehn@chromium.org, ojan@chromium.org

[leviw_travelin_and_unemployed, 2016-01-12 23:08:26]

Ping :)

[leviw_travelin_and_unemployed, 2016-01-20 06:30:20]

Ping again.

[esprehn, 2016-01-20 08:33:01]

https://codereview.chromium.org/1519123003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutCounter.cpp (right):

https://codereview.chromium.org/1519123003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutCounter.cpp:56: LayoutObject*
ancestorStyleContainmentObject(const LayoutObject& object)
static

https://codereview.chromium.org/1519123003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutCounter.cpp:58: for (LayoutObject*
ancestor = object.parent(); ancestor; ancestor = ancestor->parent()) {
I don't think this is right, this is walking the layout tree, but the below code
is walking the DOM (and style containment is also a DOM concept).

This can end up very confused if for example the element was a <dialog> and the
parent() LayoutObject was the LayoutView

[leviw_travelin_and_unemployed, 2016-01-21 07:34:22]

On 2016/01/20 at 08:33:01, esprehn wrote:
>
https://codereview.chromium.org/1519123003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/layout/LayoutCounter.cpp (right):
> 
>
https://codereview.chromium.org/1519123003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/layout/LayoutCounter.cpp:56: LayoutObject*
ancestorStyleContainmentObject(const LayoutObject& object)
> static
> 
>
https://codereview.chromium.org/1519123003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/layout/LayoutCounter.cpp:58: for (LayoutObject*
ancestor = object.parent(); ancestor; ancestor = ancestor->parent()) {
> I don't think this is right, this is walking the layout tree, but the below
code is walking the DOM (and style containment is also a DOM concept).
> 
> This can end up very confused if for example the element was a <dialog> and
the parent() LayoutObject was the LayoutView

You're totally right. PTAL.

[esprehn, 2016-02-10 02:00:02]

lgtm, but your code is busted for shadow dom. I doubt polymer and other shadow
dom apps use counters though... but you should either add a TODO or fix it here.

https://codereview.chromium.org/1519123003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutCounter.cpp (right):

https://codereview.chromium.org/1519123003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutCounter.cpp:57: for (Element*
ancestor = element.parentElement(); ancestor; ancestor =
ancestor->parentElement()) {
I think you want to use LayoutTreeTraversal::parent() to respect shadow dom?

[leviw_travelin_and_unemployed, 2016-02-16 21:17:22]

The CQ bit was checked by leviw@chromium.org

[leviw_travelin_and_unemployed, 2016-02-16 21:17:22]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/1519123003/#ps80001
(title: "Fix for shadow DOM")

[commit-bot: I haz the power, 2016-02-16 21:19:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1519123003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1519123003/80001

[commit-bot: I haz the power, 2016-02-16 22:31:46]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-16 22:55:33]

Description was changed from

==========
Implement Style Containment

The only CSS feature we support that is bound by style containment is
counters. This patch adds the concept of an enclosing style containment
ancestor to the tree walking logic in LayoutCounter and avoids crossing
these boundaries when matching counters.

Layout Containment description from spec:
https://drafts.csswg.org/css-containment/#containment-style

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/9W80Kw-z3ss
BUG=561713
==========

to

==========
Implement Style Containment

The only CSS feature we support that is bound by style containment is
counters. This patch adds the concept of an enclosing style containment
ancestor to the tree walking logic in LayoutCounter and avoids crossing
these boundaries when matching counters.

Layout Containment description from spec:
https://drafts.csswg.org/css-containment/#containment-style

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/9W80Kw-z3ss
BUG=561713

Committed: https://crrev.com/f1ded8f72e6c34c6561ba5d95ec7cff42dd82fd1
Cr-Commit-Position: refs/heads/master@{#375684}
==========

[commit-bot: I haz the power, 2016-02-16 22:55:34]

Patchset 5 (id:??) landed as
https://crrev.com/f1ded8f72e6c34c6561ba5d95ec7cff42dd82fd1
Cr-Commit-Position: refs/heads/master@{#375684}