Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1519073004: Remove always-on --harmony-rest-parameters flag (Closed)

Created:
5 years ago by adamk
Modified:
5 years ago
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove always-on --harmony-rest-parameters flag It shipped in Chrome 47. Committed: https://crrev.com/5ceb4feca3129bbaffbd30b057b182c22ab838ee Cr-Commit-Position: refs/heads/master@{#32816}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -669 lines) Patch
M src/bootstrapper.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/parsing/parser.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/parsing/parser.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/parsing/parser-base.h View 6 chunks +3 lines, -7 lines 0 comments Download
M test/cctest/compiler/test-run-jsobjects.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 13 chunks +10 lines, -32 lines 0 comments Download
M test/js-perf-test/JSTests.json View 1 chunk +0 lines, -1 line 0 comments Download
M test/message/arrow-bare-rest-param.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/arrow-missing.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/arrow-param-after-rest.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/arrow-param-after-rest-2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/arrow-two-rest-params.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/formal-parameters-bad-rest.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/invalid-spread.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/invalid-spread-2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/rest-param-class-setter-strict.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/rest-param-object-setter-sloppy.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/rest-param-object-setter-strict.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/arrow-rest-params.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/arrow-rest-params-lazy-parsing.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/es6/new-target.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/regress/regress-4211.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-508074.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/mjsunit/es6/regress/regress-513474.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/rest-params.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/rest-params-lazy-parsing.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/es6/spread-call-new-class.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/spread-call-super-property.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/super.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/harmony/arrow-rest-params.js View 1 chunk +0 lines, -144 lines 0 comments Download
D test/mjsunit/harmony/arrow-rest-params-lazy-parsing.js View 1 chunk +0 lines, -145 lines 0 comments Download
M test/mjsunit/harmony/block-sloppy-function.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/harmony/default-parameters.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/destructuring.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/harmony/regress/regress-4211.js View 1 chunk +0 lines, -12 lines 0 comments Download
D test/mjsunit/harmony/regress/regress-508074.js View 1 chunk +0 lines, -26 lines 0 comments Download
D test/mjsunit/harmony/regress/regress-513474.js View 1 chunk +0 lines, -7 lines 0 comments Download
D test/mjsunit/harmony/rest-params.js View 1 chunk +0 lines, -221 lines 0 comments Download
D test/mjsunit/harmony/rest-params-lazy-parsing.js View 1 chunk +0 lines, -33 lines 0 comments Download
M test/mjsunit/strong/declaration-after-use.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/strong/function-arity.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/strong/literals.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
5 years ago (2015-12-11 23:18:51 UTC) #2
Dan Ehrenberg
lgtm
5 years ago (2015-12-11 23:29:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1519073004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1519073004/1
5 years ago (2015-12-11 23:30:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-12 00:00:19 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-12 00:00:49 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5ceb4feca3129bbaffbd30b057b182c22ab838ee
Cr-Commit-Position: refs/heads/master@{#32816}

Powered by Google App Engine
This is Rietveld 408576698