Issue 1519063004: - Prevent running of the dart_bootstrap script by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1519063004: - Prevent running of the dart_bootstrap script by default. (Closed)

Created:
5 years ago by Ivan Posva

Modified:
5 years ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, ricow1, turnidge, rmacnak, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

- Prevent running of the dart_bootstrap script by default. - Fix argument handling in Python: argparse does not properly handle booleans. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/6d0453594acbc312e578a4ec4ef68c9ed8d8f9fe

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -11 lines)			Patch
M	runtime/observatory/observatory.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/canary.dart	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	tools/observatory_tool.py	View	4 chunks	+28 lines, -4 lines	0 comments	Download
M	tools/utils.py	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Ivan Posva

5 years ago (2015-12-11 21:23:17 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6d0453594acbc312e578a4ec4ef68c9ed8d8f9fe (presubmit successful).