components/user_prefs/tracked/tracked_preference_histogram_names.h - Issue 1519043002: Putting histogram names of tracked prefs in tracked_preference_histogram_name file.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/user_prefs/tracked/tracked_preference_histogram_names.h

Issue 1519043002: Putting histogram names of tracked prefs in tracked_preference_histogram_name file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/user_prefs/tracked/tracked_preference_helper.cc ('k') | components/user_prefs/tracked/tracked_preference_histogram_names.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_TRACKED_PREFERENCE_HISTOGRAM_NAMES_H_

	6 #define COMPONENTS_TRACKED_PREFERENCE_HISTOGRAM_NAMES_H_

	7

	8 namespace tracked_pref_histogram_names {
	Bernhard Bauer 2015/12/14 09:52:16 I think the best namespace for this would be user_ I think the best namespace for this would be user_prefs, or user_prefs::tracked. Either of those is going to be shorter (tracked_pref_histogram_names is very unwieldy in the files above), they adhere to the namespace naming convention for components, and inside of that namespace it's probably fine to use these symbols directly, i.e. not have a namespace just for this file. Deepak 2015/12/14 10:16:18 I agree, tracked_pref_histogram_names namespace is Show quoted text On 2015/12/14 09:52:16, Bernhard Bauer wrote: > I think the best namespace for this would be user_prefs, or user_prefs::tracked. > Either of those is going to be shorter (tracked_pref_histogram_names is very > unwieldy in the files above), they adhere to the namespace naming convention for > components, and inside of that namespace it's probably fine to use these symbols > directly, i.e. not have a namespace just for this file. I agree, tracked_pref_histogram_names namespace is too big. I have made this like: user_prefs::tracked and keeping the names same.
	9

	10 extern const char kTrackedPrefHistogramUnchanged[];

	11 extern const char kTrackedPrefHistogramCleared[];

	12 extern const char kTrackedPrefHistogramMigratedLegacyDeviceId[];

	13 extern const char kTrackedPrefHistogramChanged[];

	14 extern const char kTrackedPrefHistogramInitialized[];

	15 extern const char kTrackedPrefHistogramTrustedInitialized[];

	16 extern const char kTrackedPrefHistogramNullInitialized[];

	17 extern const char kTrackedPrefHistogramWantedReset[];

	18 extern const char kTrackedPrefHistogramReset[];

	19 extern const char kTrackedSplitPrefHistogramChanged[];

	20

	21 } // namespace tracked_pref_histogram_names

	22

	23 #endif // COMPONENTS_TRACKED_PREFERENCE_HISTOGRAM_NAMES_H_

OLD	NEW