Putting histogram names of tracked prefs in tracked_preference_histogram_name file.

components/user_prefs/tracked/pref_names.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_USER_PREFS_TRACKED_PREF_NAMES_H_
 #define COMPONENTS_USER_PREFS_TRACKED_PREF_NAMES_H_
 
 namespace user_prefs {
 
 extern const char kPreferenceResetTime[];
 
 }  // namespace user_prefs
 
+namespace user_tracked_prefs {

[Bernhard Bauer, 2015/12/11 14:11:44]

Why not make this an inner namespace user_prefs::tracked? That would directly
correspond to the file name.

[Deepak, 2015/12/14 03:53:45]

Now making separate file for these names.

+
+extern const char kTrackedPreferenceUnchanged[];
+extern const char kTrackedPreferenceCleared[];
+extern const char kTrackedPreferenceMigratedLegacyDeviceId[];
+extern const char kTrackedPreferenceChanged[];
+extern const char kTrackedPreferenceInitialized[];
+extern const char kTrackedPreferenceTrustedInitialized[];
+extern const char kTrackedPreferenceNullInitialized[];
+extern const char kTrackedPreferenceWantedReset[];
+extern const char kTrackedPreferenceReset[];
+extern const char kTrackedSplitPreferenceChanged[];

[Bernhard Bauer, 2015/12/11 14:11:44]

These strings aren't actually pref names, they are histogram names. (They are
histograms _about_ prefs, but not prefs themselves, in contrast to the existing
string above.)

Maybe add these to a new file histogram_names.{cc,h} or constants.{cc,h}?

[Deepak, 2015/12/14 03:53:45]

Done.

+}  // namespace user_prefs

[Bernhard Bauer, 2015/12/11 14:11:44]

Nit: empty line before.

[Deepak, 2015/12/14 03:53:45]

Done.

+
 #endif  // COMPONENTS_USER_PREFS_TRACKED_PREF_NAMES_H_