components/user_prefs/tracked/tracked_preference_histogram_names.h - Issue 1519043002: Putting histogram names of tracked prefs in tracked_preference_histogram_name file.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/user_prefs/tracked/tracked_preference_histogram_names.h

Issue 1519043002: Putting histogram names of tracked prefs in tracked_preference_histogram_name file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/user_prefs/tracked/tracked_preference_helper.cc ('k') | components/user_prefs/tracked/tracked_preference_histogram_names.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_USER_PREFS_TRACKED_TRACKED_PREFERENCE_HISTOGRAM_NAMES_H_

	6 #define COMPONENTS_USER_PREFS_TRACKED_TRACKED_PREFERENCE_HISTOGRAM_NAMES_H_

	7

	8 namespace user_prefs {

	9 namespace tracked {

	10

	11 extern const char kTrackedPrefHistogramUnchanged[];

	12 extern const char kTrackedPrefHistogramCleared[];

	13 extern const char kTrackedPrefHistogramMigratedLegacyDeviceId[];

	14 extern const char kTrackedPrefHistogramChanged[];

	15 extern const char kTrackedPrefHistogramInitialized[];

	16 extern const char kTrackedPrefHistogramTrustedInitialized[];

	17 extern const char kTrackedPrefHistogramNullInitialized[];

	18 extern const char kTrackedPrefHistogramWantedReset[];

	19 extern const char kTrackedPrefHistogramReset[];

	20 extern const char kTrackedSplitPrefHistogramChanged[];

	21

	22 } // namespace tracked.
	Bernhard Bauer 2015/12/15 11:19:55 No period at the end. Essentially, the comment sho No period at the end. Essentially, the comment should exactly mirror the statement the opened the namespace. Deepak 2015/12/15 11:28:28 Done. Sorry I missed that. Show quoted text On 2015/12/15 11:19:55, Bernhard Bauer wrote: > No period at the end. Essentially, the comment should exactly mirror the > statement the opened the namespace. Done. Sorry I missed that.
	23 } // namespace user_prefs.

	24

	25 #endif // COMPONENTS_USER_PREFS_TRACKED_TRACKED_PREFERENCE_HISTOGRAM_NAMES_H_

OLD	NEW