Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 151903007: Introduces UMA for app-list voice search. (Closed)

Created:
6 years, 10 months ago by Jun Mukai
Modified:
6 years, 10 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, sadrul, jar (doing other things), tfarina, asvitkine+watch_chromium.org, kalyank, Ilya Sherman, ben+ash_chromium.org, rpetterson
Visibility:
Public.

Description

Introduces UMA for app-list voice search. This CL adds 6 user actions (prefixed by 'AppList_') - AutoLaunchCanceled - AutoLaunched - HotwordRecognized - SearchedBySpeech - VoiceSearchCanceled - VoiceSearchStartedManually BUG=341239 R=xiyuan@chromium.org TBR=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251359

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -10 lines) Patch
M ash/shell/app_list.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/start_page_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/start_page_service.cc View 6 chunks +34 lines, -1 line 0 comments Download
M tools/metrics/actions/chromeactions.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/app_list/app_list_view_delegate.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/app_list/cocoa/app_list_view_controller.mm View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/app_list/test/app_list_test_view_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/test/app_list_test_view_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/views/app_list_main_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/views/app_list_main_view.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/app_list/views/search_result_list_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/views/search_result_list_view_delegate.h View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
Jun Mukai
This CL depends on https://codereview.chromium.org/158143002/
6 years, 10 months ago (2014-02-10 23:01:17 UTC) #1
xiyuan
lgtm
6 years, 10 months ago (2014-02-10 23:28:54 UTC) #2
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 10 months ago (2014-02-13 23:28:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/151903007/1
6 years, 10 months ago (2014-02-13 23:31:44 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 23:59:09 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=50226
6 years, 10 months ago (2014-02-13 23:59:09 UTC) #6
Jun Mukai
On 2014/02/13 23:59:09, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 10 months ago (2014-02-14 02:37:39 UTC) #7
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 10 months ago (2014-02-14 02:37:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/151903007/1
6 years, 10 months ago (2014-02-14 02:41:48 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 03:51:56 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-14 03:51:56 UTC) #11
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 10 months ago (2014-02-14 09:19:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/151903007/1
6 years, 10 months ago (2014-02-14 09:19:41 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 09:20:20 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-14 09:20:20 UTC) #15
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 10 months ago (2014-02-14 09:39:23 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/151903007/1
6 years, 10 months ago (2014-02-14 09:40:47 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 09:41:52 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-14 09:41:53 UTC) #19
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 10 months ago (2014-02-14 17:11:25 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/151903007/1
6 years, 10 months ago (2014-02-14 17:12:11 UTC) #21
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 17:13:34 UTC) #22
Message was sent while issue was closed. 
Change committed as 251359

Powered by Google App Engine
This is Rietveld 408576698