Issue 1519018: Update test shell for new dragImage api....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1519018: Update test shell for new dragImage api.... (Closed)

Created:
10 years, 8 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Nico, Jens Alfke

CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Update test shell for new dragImage api. I don't think this actually caused the layout test failures, but it is worth tidying up anyway. patch mostly by Nico Weber BUG=none TEST=layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43653

Patch Set 1 #

Patch Set 2 : alphabet #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -7 lines)			Patch
M	webkit/tools/test_shell/event_sending_controller.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	webkit/tools/test_shell/event_sending_controller.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	1	4 chunks	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

LG (quelle surprise) Without this, testshell didn't override the startDragging() method that's called by webkit, ...

10 years, 8 months ago (2010-04-05 20:57:35 UTC) #2

Evan Stade

10 years, 8 months ago (2010-04-05 21:00:58 UTC) #3

the problem is that createDragImageForSelection still returns NULL and
we dereferenced it.

-- Evan Stade



On Mon, Apr 5, 2010 at 1:57 PM,  <thakis@chromium.org> wrote:
> LG (quelle surprise)
>
> Without this, testshell didn't override the startDragging() method that's
> called
> by webkit, which is why I though this might cause test problems. But I guess
> you
> tried it, and practice beats theory :-P
>
> http://codereview.chromium.org/1519018
>

Expand Messages | Collapse Messages