Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 1519013003: [wasm] Change the return type of traps for tests, and added ftoi64 instructions. (Closed)

Created:
5 years ago by ahaas
Modified:
5 years ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@f32toui64
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Change the return type of traps for tests, and added ftoi64 instructions. Before this change traps always returned a 32 bit word in tests. With this change traps return either a 32 bit word or a64 bit word, depending on the size of the actual return value of the test. Additionally this CL implements the wasm instructions I64SCONVERTF32, I64UCONVERTF32, I64SCONVERTF64, and I64UCONVERTF64. R=titzer@chromium.org Committed: https://crrev.com/d83057b4ce27e9852cdca8a90d5bab9dcb4b6489 Cr-Commit-Position: refs/heads/master@{#32800}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -27 lines) Patch
M src/compiler/wasm-compiler.h View 3 chunks +4 lines, -1 line 0 comments Download
M src/compiler/wasm-compiler.cc View 1 7 chunks +68 lines, -9 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 9 chunks +76 lines, -17 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
ahaas
5 years ago (2015-12-11 13:42:35 UTC) #1
titzer
lgtm other than one comment https://codereview.chromium.org/1519013003/diff/1/src/compiler/wasm-compiler.cc File src/compiler/wasm-compiler.cc (right): https://codereview.chromium.org/1519013003/diff/1/src/compiler/wasm-compiler.cc#newcode231 src/compiler/wasm-compiler.cc:231: ret_dead = graph()->NewNode(jsgraph()->common()->Return(), You ...
5 years ago (2015-12-11 13:49:26 UTC) #2
ahaas
On 2015/12/11 at 13:49:26, titzer wrote: > lgtm other than one comment > > https://codereview.chromium.org/1519013003/diff/1/src/compiler/wasm-compiler.cc ...
5 years ago (2015-12-11 14:28:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1519013003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1519013003/20001
5 years ago (2015-12-11 14:28:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-11 14:54:15 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-11 14:54:28 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d83057b4ce27e9852cdca8a90d5bab9dcb4b6489
Cr-Commit-Position: refs/heads/master@{#32800}

Powered by Google App Engine
This is Rietveld 408576698