Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1518933002: Use SK_BUILD_FOR_ANDROID_FRAMEWORK in compose (Closed)

Created:
5 years ago by scroggo
Modified:
5 years ago
Reviewers:
djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use SK_BUILD_FOR_ANDROID_FRAMEWORK in compose We are trying to support the behavior provided by the Android framework. Other developers do not necessarily need this behavior. BUG=skia:4296 Committed: https://skia.googlesource.com/skia/+/ce5ac45d39db3c7fe52acaa59117688aec53710e

Patch Set 1 #

Patch Set 2 : Add comments #

Patch Set 3 : Update comment - Android ignores the paint's alpha #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/core/SkComposeShader.cpp View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
scroggo
5 years ago (2015-12-10 22:40:53 UTC) #2
scroggo
On 2015/12/10 22:40:53, scroggo wrote: ping. Although this doesn't "fix" anything, I think the new ...
5 years ago (2015-12-16 15:17:03 UTC) #3
reed1
lgtm
5 years ago (2015-12-16 15:19:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518933002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518933002/40001
5 years ago (2015-12-16 15:20:30 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-16 15:34:25 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/ce5ac45d39db3c7fe52acaa59117688aec53710e

Powered by Google App Engine
This is Rietveld 408576698