Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 151893002: Reorganize apps/shell into app, browser and common directories (Closed)

Created:
6 years, 10 months ago by James Cook
Modified:
6 years, 10 months ago
Reviewers:
miket_OOO, Jói
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, tfarina, chromium-apps-reviews_chromium.org, kalyank, ben+ash_chromium.org
Visibility:
Public.

Description

Reorganize apps/shell into app, browser and common directories. This allows us to separate browser process, render process and common code, similar to how content/shell is organized. This also allows the DEPS files to be more restrictive to enforce those dependencies. A parallel CL adds apps/shell/renderer and some renderer-specific code: https://codereview.chromium.org/149163002/ BUG=none TEST=compiles R=joi@chromium.org, miket@chromium.org TBR=stevenjb@chromium.org for DEPS on src/chromeos (just moving the DEP from one file to another) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248575

Patch Set 1 #

Patch Set 2 : subdirs #

Total comments: 1

Patch Set 3 : fix ash (subdirs) #

Total comments: 1

Patch Set 4 : rebase (subdirs) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -1872 lines) Patch
M apps/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M apps/apps.gypi View 1 2 3 1 chunk +21 lines, -21 lines 0 comments Download
D apps/shell/DEPS View 1 2 3 1 chunk +0 lines, -18 lines 0 comments Download
A apps/shell/app/DEPS View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
A apps/shell/app/README View 1 chunk +5 lines, -0 lines 0 comments Download
A + apps/shell/app/shell_main.cc View 1 chunk +1 line, -1 line 0 comments Download
A + apps/shell/app/shell_main_delegate.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + apps/shell/app/shell_main_delegate.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A + apps/shell/browser/DEPS View 1 2 3 1 chunk +13 lines, -8 lines 0 comments Download
A + apps/shell/browser/shell_app_sorting.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + apps/shell/browser/shell_app_sorting.cc View 1 chunk +1 line, -1 line 0 comments Download
A + apps/shell/browser/shell_browser_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + apps/shell/browser/shell_browser_context.cc View 1 chunk +1 line, -1 line 0 comments Download
A + apps/shell/browser/shell_browser_main_parts.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + apps/shell/browser/shell_browser_main_parts.cc View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
A + apps/shell/browser/shell_content_browser_client.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + apps/shell/browser/shell_content_browser_client.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
A + apps/shell/browser/shell_extension_system.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + apps/shell/browser/shell_extension_system.cc View 1 chunk +1 line, -1 line 0 comments Download
A + apps/shell/browser/shell_extensions_browser_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + apps/shell/browser/shell_extensions_browser_client.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + apps/shell/browser/web_view_window.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + apps/shell/browser/web_view_window.cc View 1 chunk +1 line, -1 line 0 comments Download
A apps/shell/common/DEPS View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
A + apps/shell/common/shell_content_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + apps/shell/common/shell_content_client.cc View 1 chunk +1 line, -1 line 0 comments Download
A + apps/shell/common/shell_extensions_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + apps/shell/common/shell_extensions_client.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M apps/shell/renderer/DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M apps/shell/renderer/shell_content_renderer_client.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D apps/shell/shell_app_sorting.h View 1 chunk +0 lines, -64 lines 0 comments Download
D apps/shell/shell_app_sorting.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D apps/shell/shell_browser_context.h View 1 chunk +0 lines, -44 lines 0 comments Download
D apps/shell/shell_browser_context.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D apps/shell/shell_browser_main_parts.h View 1 chunk +0 lines, -94 lines 0 comments Download
D apps/shell/shell_browser_main_parts.cc View 1 2 3 1 chunk +0 lines, -160 lines 0 comments Download
D apps/shell/shell_content_browser_client.h View 1 2 3 1 chunk +0 lines, -57 lines 0 comments Download
D apps/shell/shell_content_browser_client.cc View 1 2 3 1 chunk +0 lines, -158 lines 0 comments Download
D apps/shell/shell_content_client.h View 1 chunk +0 lines, -33 lines 0 comments Download
D apps/shell/shell_content_client.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D apps/shell/shell_extension_system.h View 1 chunk +0 lines, -92 lines 0 comments Download
D apps/shell/shell_extension_system.cc View 1 chunk +0 lines, -177 lines 0 comments Download
D apps/shell/shell_extensions_browser_client.h View 1 chunk +0 lines, -66 lines 0 comments Download
D apps/shell/shell_extensions_browser_client.cc View 1 chunk +0 lines, -135 lines 0 comments Download
D apps/shell/shell_extensions_client.h View 1 chunk +0 lines, -49 lines 0 comments Download
D apps/shell/shell_extensions_client.cc View 1 2 3 1 chunk +0 lines, -145 lines 0 comments Download
D apps/shell/shell_main.cc View 1 chunk +0 lines, -11 lines 0 comments Download
D apps/shell/shell_main_delegate.h View 1 2 3 1 chunk +0 lines, -47 lines 0 comments Download
D apps/shell/shell_main_delegate.cc View 1 2 3 1 chunk +0 lines, -102 lines 0 comments Download
D apps/shell/web_view_window.h View 1 chunk +0 lines, -24 lines 0 comments Download
D apps/shell/web_view_window.cc View 1 chunk +0 lines, -83 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
James Cook
joi, PTAL at the DEPS file structure. I split apps/shell/DEPS into apps, browser and common ...
6 years, 10 months ago (2014-02-01 00:49:20 UTC) #1
Jói
LGTM https://codereview.chromium.org/151893002/diff/100001/apps/DEPS File apps/DEPS (right): https://codereview.chromium.org/151893002/diff/100001/apps/DEPS#newcode3 apps/DEPS:3: "+content/public/browser", Would it make sense to use more ...
6 years, 10 months ago (2014-02-03 10:43:13 UTC) #2
James Cook
miket, can I get OWNERS for apps/apps.gypi? (I've also sent you a CL to extend ...
6 years, 10 months ago (2014-02-03 17:41:56 UTC) #3
miket_OOO
On 2014/02/03 17:41:56, James Cook wrote: > miket, can I get OWNERS for apps/apps.gypi? > ...
6 years, 10 months ago (2014-02-03 18:39:06 UTC) #4
James Cook
6 years, 10 months ago (2014-02-03 21:19:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r248575 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698