`ErrorCode` enum update.

`ErrorCode` enum update.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/9f91ef808064ff5d44e1c552b905220f83c07eff

[pquitslund, 2015-12-10 22:36:56]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-12-10 23:40:44]

LGTM, but this seems like a common breakage pattern. Perhaps we should have a
test that ensures that all of the defined codes have been included in these
lists so that we catch this when we add the codes.

[pquitslund, 2015-12-11 17:52:25]

On 2015/12/10 23:40:44, Brian Wilkerson wrote:
> LGTM, but this seems like a common breakage pattern. Perhaps we should have a
> test that ensures that all of the defined codes have been included in these
> lists so that we catch this when we add the codes.

Absolutely.  This approach is the pits long-term.  I actually started writing a
code generator when I introduced the enum but decided to hold off until we had
the revamped error code model.  Might re-think that though!

[pquitslund, 2015-12-11 18:11:55]

Description was changed from

==========
`ErrorCode` enum update.
==========

to

==========
`ErrorCode` enum update.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9f91ef808064ff5d44e1c552b905220f83c07eff
==========

[pquitslund, 2015-12-11 18:11:57]

Committed patchset #1 (id:1) manually as
9f91ef808064ff5d44e1c552b905220f83c07eff (presubmit successful).