android_webview/lib/main/aw_main_delegate.cc - Issue 1518913002: [Android WebView] Update microdump generation for sandboxed renderers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/lib/main/aw_main_delegate.cc

Issue 1518913002: [Android WebView] Update microdump generation for sandboxed renderers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed typo Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwDebugTest.java ('k') | components/crash/content/app/breakpad_linux.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/lib/main/aw_main_delegate.cc

diff --git a/android_webview/lib/main/aw_main_delegate.cc b/android_webview/lib/main/aw_main_delegate.cc

index 79dac36a2ecf812f89efba22d0e395e15443f6d4..c9340ff867e31a1290abfa148eb5f25f4b189a2f 100644

--- a/android_webview/lib/main/aw_main_delegate.cc

+++ b/android_webview/lib/main/aw_main_delegate.cc

@@ -170,8 +170,13 @@ void AwMainDelegate::PreSandboxStartup() {

ResourceBundle::GetSharedInstance().AddDataPackFromFileRegion(

base::File(pak_fd), pak_region, ui::SCALE_FACTOR_NONE);

}

+ if (process_type.empty() &&

+ command_line.HasSwitch(switches::kSingleProcess)) {

+ // "webview" has a special treatment in breakpad_linux.cc.

+ process_type = "webview";

+ }

- crash_reporter::EnableMicrodumpCrashReporter();

+ crash_reporter::EnableMicrodumpCrashReporter(process_type);

}

int AwMainDelegate::RunProcess(