android_webview/crash_reporter/aw_microdump_crash_reporter.cc - Issue 1518913002: [Android WebView] Update microdump generation for sandboxed renderers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/crash_reporter/aw_microdump_crash_reporter.cc

Issue 1518913002: [Android WebView] Update microdump generation for sandboxed renderers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed typo Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/crash_reporter/aw_microdump_crash_reporter.h ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwDebugTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/crash_reporter/aw_microdump_crash_reporter.cc

diff --git a/android_webview/crash_reporter/aw_microdump_crash_reporter.cc b/android_webview/crash_reporter/aw_microdump_crash_reporter.cc

index 165c4b313f12046ef25f37858e692220ecfb29a8..aac36e8c35324ff47551cb6dbf928975b0a0fef3 100644

--- a/android_webview/crash_reporter/aw_microdump_crash_reporter.cc

+++ b/android_webview/crash_reporter/aw_microdump_crash_reporter.cc

@@ -109,7 +109,7 @@ bool SafeToUseSignalHandler() {

} // namespace

-void EnableMicrodumpCrashReporter() {

+void EnableMicrodumpCrashReporter(const std::string& process_type) {

if (g_enabled) {

NOTREACHED() << "EnableMicrodumpCrashReporter called more than once";

return;

@@ -124,8 +124,7 @@ void EnableMicrodumpCrashReporter() {

::crash_reporter::SetCrashReporterClient(g_crash_reporter_client.Pointer());

- // |process_type| is not really relevant here, as long as it not empty.

- breakpad::InitNonBrowserCrashReporterForAndroid("webview" /* process_type */);

+ breakpad::InitMicrodumpCrashHandlerIfNecessary(process_type);

g_enabled = true;

}