Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1518893003:
SkPaint::kGenA8FromLCD_Flagis no longer used, so remove references to it (Closed)
|
Created:
5 years ago by reed1 Modified:
5 years ago CC:
chromium-reviews, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, Rik, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, danakj, krit, f(malita), blink-reviews, vmpstr+blinkwatch_chromium.org, Stephen Chennney, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSkPaint::kGenA8FromLCD_Flagis no longer used, so remove references to it.
BUG=skia:4685
Committed: https://crrev.com/44df461bc4915ca52e017131dcfc001e9d63e2ee
Cr-Commit-Position: refs/heads/master@{#364764}
Patch Set 1 #
Total comments: 2
Patch Set 2 : #
Messages
Total messages: 33 (15 generated)
The CQ bit was checked by reed@google.com to run a CQ dry run
reed@google.com changed reviewers: + bungeman@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518893003/1
Description was changed from ========== SkPaint::kGenA8FromLCD_Flagis no longer used, so remove references to it BUG= ========== to ========== SkPaint::kGenA8FromLCD_Flagis no longer used, so remove references to it. ==========
https://codereview.chromium.org/1518893003/diff/1/skia/ext/benchmarking_canva... File skia/ext/benchmarking_canvas.cc (right): https://codereview.chromium.org/1518893003/diff/1/skia/ext/benchmarking_canva... skia/ext/benchmarking_canvas.cc:242: builder.addFlag(false, "GenA8FromLCD"); Can this just be deleted? It doesn't seem to be needed. https://codereview.chromium.org/1518893003/diff/1/third_party/WebKit/Source/p... File third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp (right): https://codereview.chromium.org/1518893003/diff/1/third_party/WebKit/Source/p... third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp:335: appendFlagToString(&flagsString, false, "GenA8FromLCD"); Same here, seems we'd rather delete it.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
of course they should be deleted. I was just being conservative in case some unittest always expected to "see" that tag. Since everything passed, I'll try again with those lines gone.
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518893003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518893003/20001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== SkPaint::kGenA8FromLCD_Flagis no longer used, so remove references to it. ========== to ========== SkPaint::kGenA8FromLCD_Flagis no longer used, so remove references to it. BUG=skia:4685 ==========
reed@google.com changed reviewers: + fmalita@chromium.org
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518893003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518893003/20001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by reed@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518893003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518893003/20001
lgtm, but I think you need an OWNER.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by fmalita@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518893003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518893003/20001
Message was sent while issue was closed.
Description was changed from ========== SkPaint::kGenA8FromLCD_Flagis no longer used, so remove references to it. BUG=skia:4685 ========== to ========== SkPaint::kGenA8FromLCD_Flagis no longer used, so remove references to it. BUG=skia:4685 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== SkPaint::kGenA8FromLCD_Flagis no longer used, so remove references to it. BUG=skia:4685 ========== to ========== SkPaint::kGenA8FromLCD_Flagis no longer used, so remove references to it. BUG=skia:4685 Committed: https://crrev.com/44df461bc4915ca52e017131dcfc001e9d63e2ee Cr-Commit-Position: refs/heads/master@{#364764} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/44df461bc4915ca52e017131dcfc001e9d63e2ee Cr-Commit-Position: refs/heads/master@{#364764} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
