Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1518873004: [es6] Support Function name inference in variable declarations (Closed)

Created:
5 years ago by adamk
Modified:
5 years ago
Reviewers:
Dan Ehrenberg
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Support Function name inference in variable declarations This is behind the --harmony-function-name flag, currently disabled. With the flag enabled, we now pass the relevant tests in language/statements/*/fn-name-*. BUG=v8:3699 LOG=y Committed: https://crrev.com/819c429ca20cf0721f99e8a6cbdbed1472310a15 Cr-Commit-Position: refs/heads/master@{#32817}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -4 lines) Patch
M src/ast/ast.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser.cc View 3 chunks +17 lines, -0 lines 0 comments Download
M src/parsing/parser-base.h View 3 chunks +4 lines, -1 line 0 comments Download
A test/mjsunit/harmony/function-name.js View 1 chunk +35 lines, -0 lines 0 comments Download
M test/test262/test262.status View 2 chunks +1 line, -3 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
adamk
5 years ago (2015-12-11 22:59:32 UTC) #2
Dan Ehrenberg
lgtm Looks great. Please ignore the comment below--a bug in the UI seems to make ...
5 years ago (2015-12-12 00:09:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518873004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518873004/1
5 years ago (2015-12-12 00:16:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-12 00:20:07 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-12 00:20:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/819c429ca20cf0721f99e8a6cbdbed1472310a15
Cr-Commit-Position: refs/heads/master@{#32817}

Powered by Google App Engine
This is Rietveld 408576698